cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11721) Android InAppBrowser Previous, Next page history buttons do not change with the state of the content
Date Wed, 24 Aug 2016 19:35:21 GMT

    [ https://issues.apache.org/jira/browse/CB-11721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435524#comment-15435524
] 

ASF GitHub Bot commented on CB-11721:
-------------------------------------

GitHub user justforgolly opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/182

    CB-11721 android: InAppBrowser history buttons fix

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    CB-11721 - back and forward history buttons for Android InAppBrowser improved to show
state of the content. e.g. if the user cannot browse forward in history, the forward button
will be faded out.
    
    ### What testing has been done on this change?
    npm test for jshint
    automated tests with cordova-plugin-test-framework
    cordova-paramedic for android plugin
    no new test code
    
     
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    
    - back and forward history buttons now change color based on the state of the content

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justforgolly/cordova-plugin-inappbrowser CB-11721

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #182
    
----
commit 9909b3509012df57921268a9295cfc6edf71350e
Author: Arjun Thounaojam <justforgolly@gmail.com>
Date:   2016-08-23T22:28:26Z

    CB-11721 android: InAppBrowser history buttons fix
    
    - back and forward history buttons now change color based on the state of the content

----


> Android InAppBrowser Previous, Next page history buttons do not change with the state
of the content
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CB-11721
>                 URL: https://issues.apache.org/jira/browse/CB-11721
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin InAppBrowser
>    Affects Versions: Master
>         Environment: Android OS 6.0.1, Cordova CLI 6.3.1, cordova-android 5.2.1, cordova-plugin-inappbrowser
1.4.0
>            Reporter: Arjun Thounaojam
>              Labels: android, triaged
>         Attachments: InAppBrowserAndroidCurrentHistoryButtons.png, InAppBrowserAndroidImprovedHistoryButtons.png
>
>
> Steps to reproduce:
> 1) Create a simple Cordova Android app with the InAppBrowser plugin pointing to a website.
E.g. https://news.google.com
> 2) Navigate back and forth between different pages
> 3) Observe the history buttons on the toolbar
> Expected behavior:
> The Previous / Next arrow buttons should become highlighted or faded based on where in
the page history the content is.
> This behavior is standard on most browsers. The iOS InAppBrowser implements it too.
> Observed behavior:
> The Previous / Next buttons remain highlighted regardless of if it's possible to navigate
back or forward in the content.
> This was never implemented for Android so wasn't sure if Issue Type should be a Bug or
Improvement. Left it at default.
> I have a potential implementation. Will fork repo and trigger a pull request soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message