cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
Date Sun, 21 Aug 2016 21:53:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429909#comment-15429909
] 

ASF GitHub Bot commented on CB-11714:
-------------------------------------

GitHub user DisruptiveMind opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/232

    CB-11714: (windows) added more explicit content-type when converting …

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Adds an explicit check for PNG/JPEG to set the content type when converting to target
data URL in resizeImage()
    
    ### What testing has been done on this change?
    Manual testing has been done using a Windows 10 Desktop.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    …nvas

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DisruptiveMind/cordova-plugin-camera CB-11714

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #232
    
----
commit 6833cd17523392751c6962562d9d7dd392550f0f
Author: Tyler Pham <tyler@disruptiveart.com>
Date:   2016-08-21T21:50:35Z

    CB-11714: (windows) added more explicit content-type when converting to target data on
canvas

----


> Camera plugin for windows does not properly set content-type when selecting JPG->PNG
> ------------------------------------------------------------------------------------
>
>                 Key: CB-11714
>                 URL: https://issues.apache.org/jira/browse/CB-11714
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: Master
>         Environment: Windows 10
>            Reporter: Tyler Pham
>              Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the resizeImage() will
not modify the target content type when converting canvas.toDataURL(...) -- the content-type
will still be image/jpeg but with a .png extension which will cause the browser to not render
to image and issue an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message