cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11712) <name> changes in config.xml does a "search and replace all" for occurrences of the old name with the new name in the pbxproj
Date Wed, 31 Aug 2016 02:23:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450820#comment-15450820
] 

ASF GitHub Bot commented on CB-11712:
-------------------------------------

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/246

    CB-11712 - <name> changes in config.xml does a 'search and replace all' for occurrences
of the old name with the new name in the pbxproj

    The error message looks like this:
    ```
    Error: The product name change (<name> tag) in config.xml is not supported dynamically.
    To change your product name, you have to remove, then add your ios platform again.
    Make sure you save your plugins beforehand using `cordova plugin save`.
           	cordova plugin save
           	cordova platform rm ios
           	cordova platform add ios
    ```
    
    Not sure if I'm supposed to be hardcoding `cordova` for downstream distributions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-11712

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
    
----
commit 5ec6fecf889f7050055d423dd89d5418c5a93865
Author: Shazron Abdullah <shazron@apache.org>
Date:   2016-08-31T02:20:39Z

    CB-11712 - <name> changes in config.xml does a 'search and replace all' for occurrences
of the old name with the new name in the pbxproj

----


> <name> changes in config.xml does a "search and replace all" for occurrences of
the old name with the new name in the pbxproj
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-11712
>                 URL: https://issues.apache.org/jira/browse/CB-11712
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: iOS
>    Affects Versions: 4.2.0
>         Environment: iOS
> cordova 6.3.1
> cordova-ios 4.2.0
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>            Priority: Critical
>              Labels: triaged
>
> Actual result:
> Changing the project name in the config.xml <name> tag will *not* replace the project
name properly, and you *cannot* build the project.
> Expected result:
> Changing the project name in the config.xml <name> tag will replace the project
name properly, and you can build the project.
> Repro steps:
> 1. `cordova create t t t`
> 2. `cd t`
> 3. `cordova platform add ios`
> 4. `cordova build`
> 5. Edit config.xml <name> tag, and replace "t" with "foobar"
> 6. `cordova build`
> Check the file `platforms\ios\foobar.xcodeproj\project.pbxproj`. All `t` characters have
been replaced with `foobar`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message