cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-11712) <name> changes in config.xml does a "search and replace all" for occurrences of the old name with the new name in the pbxproj
Date Wed, 17 Aug 2016 00:22:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423648#comment-15423648
] 

Shazron Abdullah edited comment on CB-11712 at 8/17/16 12:21 AM:
-----------------------------------------------------------------

Ok, I think after discussion with [~purplecabbage] that this is what we will be going with:

1. <name> changes in config.xml will *not* be supported (hold your flames, wait for
the explanation below)
2. If you did a <name> change, we will put out an error saying that it is not supported,
and tell you how to "fix" it

The fix would be, as stated in the error message in (2), for you to do a:
{code}
cordova platform rm ios
cordova platform add ios
{code}

Since <name> config.xml changes are usually infrequent, it should be fine. The cordova
code that handles name changes dynamically is (as demonstrated) pretty hack-ish, and we will
not add to the hack (but instead delete it).

The platforms folder is considered a build artifact so it is fine to recommend this. Make
sure you do this beforehand, if you didn't save your plugins:
{code}
cordova plugin save
{code}

This will save a list of your installed plugins in config.xml


was (Author: shazron):
Ok, I think after discussion with [~purplecabbage] that this is what we will be going with:

1. <name> changes in config.xml will *not* be supported (hold your flames, wait for
the explanation below)
2. If you did a <name> change, we will put out an error saying that it is not supported,
and tell you how to "fix" it

The fix would be, as stated in the error message in (2), for you to do a:
{code}
cordova platform rm ios
cordova platform add ios
{code}

Since <name> config.xml changes are usually infrequent, it should be fine. The cordova
code that handles name changes dynamically is (as demonstrated) pretty hack-ish, and we will
not add to the hack (but instead delete it).

> <name> changes in config.xml does a "search and replace all" for occurrences of
the old name with the new name in the pbxproj
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-11712
>                 URL: https://issues.apache.org/jira/browse/CB-11712
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>         Environment: iOS
> cordova 6.3.1
> cordova-ios 4.2.0
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>            Priority: Critical
>
> Actual result:
> Changing the project name in the config.xml <name> tag will *not* replace the project
name properly, and you *cannot* build the project.
> Expected result:
> Changing the project name in the config.xml <name> tag will replace the project
name properly, and you can build the project.
> Repro steps:
> 1. `cordova create t t t`
> 2. `cd t`
> 3. `cordova platform add ios`
> 4. `cordova build`
> 5. Edit config.xml <name> tag, and replace "t" with "foobar"
> 6. `cordova build`
> Check the file `platforms\ios\foobar.xcodeproj\project.pbxproj`. All `t` characters have
been replaced with `foobar`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message