cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11677) in cordova-plugin-dialogs prompt text is invisible
Date Thu, 11 Aug 2016 12:58:22 GMT

    [ https://issues.apache.org/jira/browse/CB-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417173#comment-15417173
] 

ASF GitHub Bot commented on CB-11677:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/81#discussion_r74416632
  
    --- Diff: src/android/Notification.java ---
    @@ -286,7 +286,9 @@ public synchronized void prompt(final String message, final String
title, final
             Runnable runnable = new Runnable() {
                 public void run() {
                     final EditText promptInput =  new EditText(cordova.getActivity());
    -                promptInput.setHint(defaultText);
    +                final int promptInputColor = 0xff444444;
    --- End diff --
    
    @matrosovN, i think you should avoid using 'magic' numbers. IMO this value should be read
from resources, rather than hardcoded.


> in cordova-plugin-dialogs prompt text is invisible
> --------------------------------------------------
>
>                 Key: CB-11677
>                 URL: https://issues.apache.org/jira/browse/CB-11677
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin Dialogs
>    Affects Versions: 1.2.1
>         Environment: ionic-framework 1.1
> Android
> Windows 10
>            Reporter: dinesh
>              Labels: easyfix, newbie
>
> dialog prompt text color is not set. As a result the text appears invisible to the user.
> I added c. line 290 in src\Notification.java in function prompt() to temporarily get
around this problem 
> promptInput.setTextColor(0xff444444);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message