cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-11554) too "brutal" app reload when title is empty
Date Sat, 06 Aug 2016 00:35:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410327#comment-15410327
] 

Shazron Abdullah edited comment on CB-11554 at 8/6/16 12:34 AM:
----------------------------------------------------------------

The tests check for "shouldReloadWebView" returning:
1. YES for an about:blank page
2. NO for a (non about:blank page) with document.title as empty string
3. YES for any page where document.title is nil

Circular loads will need to be detected as well (in case your desired page is already about:blank)


was (Author: shazron):
The tests check for "shouldReloadWebView" returning:
1. YES for an about:blank page
2. NO for a (non about:blank page) with document.title as empty string
3. YES for any page where document.title is nil


> too "brutal" app reload when title is empty
> -------------------------------------------
>
>                 Key: CB-11554
>                 URL: https://issues.apache.org/jira/browse/CB-11554
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin WKWebViewEngine
>    Affects Versions: 1.0.4-dev
>            Reporter: Philippe Wang
>            Assignee: Shazron Abdullah
>              Labels: iOS, ios, regression, triaged
>
> This patch 
> https://github.com/apache/cordova-plugin-wkwebview-engine/commit/815ed0741b9ae30b343d6429bd8ff2ad37ec5790
> introduces {if title is empty then reload the app}.
> It was really hard for me to find the reason why the app I'm working on kept reloading
on each resume, while I had an older build of my app not having this bad feature. Shouldn't
there be at least a warning message explaining why the app reloads? It'd be even better to
find some better criteria.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message