cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11380) Media Plugin - IOS: Error when creating Media object with new file
Date Thu, 25 Aug 2016 11:25:21 GMT

    [ https://issues.apache.org/jira/browse/CB-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436691#comment-15436691
] 

ASF GitHub Bot commented on CB-11380:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/112

    CB-11380 (ios) Fixed an unexpected error callback when initializing M…

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Eliminates an unexpected error callback when initializing Media with the file that doesn't
exist:
    https://issues.apache.org/jira/browse/CB-11380
    
    ### What testing has been done on this change?
    Tested manually on iOS 8.1
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-media CB-11380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----
commit 0b4c67e524ee7d4b411d4527bb9347442cd8ea16
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-08-25T11:21:41Z

    CB-11380 (ios) Fixed an unexpected error callback when initializing Media with file that
doesn't exist

----


> Media Plugin - IOS: Error when creating Media object with new file
> ------------------------------------------------------------------
>
>                 Key: CB-11380
>                 URL: https://issues.apache.org/jira/browse/CB-11380
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin Media
>    Affects Versions: 2.3.0
>         Environment: iOS 9.3.1
>            Reporter: John Keating
>            Assignee: Alexander Sorokin
>              Labels: ios, media, url
>
> The line:
> {code:borderStyle=solid}var myMedia = new Media("documents://hello.wav",
>    function() {
>         console.log("success");
>    },
>    function(er) {
>         console.log(er);
>    }
> );
> {code}
> results in the error "Cannot use audio file from resource 'documents:hello.wav'", when
"hello.wav" does not exist.  The created Media object is usable (I can record and play back),
but the error means the constructor's success callback never gets called.  Also happens with
variations of the src URI using "file" and "cdvfile".
> This is caused by a change to the validation parameter from NO to YES in commit e5b663ac951b2d8cb2e5e470d2c7072aa56cf779
on March 2nd.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message