cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11281) Prompt dialog: defaultText is not taken as input if no input by user
Date Tue, 23 Aug 2016 19:32:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433446#comment-15433446
] 

ASF GitHub Bot commented on CB-11281:
-------------------------------------

GitHub user DeshanKTD opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/83

    CB-11281 windows: defaultText is taken as input for empty input field

    
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    CB-11281 issue fixed. If there is no input by user in prompt dialog, default text is not
taken as input. That issue is fixed.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DeshanKTD/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #83
    
----
commit 484ad35659d50b2d66539b6a7b77ffde6d76d7f5
Author: DeshanKTD <deshankalupahana@gmail.com>
Date:   2016-08-23T19:23:48Z

    CB-11281 windows: defaultText is not taken as input if no input by user fixed

----


> Prompt dialog: defaultText is not taken as input if no input by user
> --------------------------------------------------------------------
>
>                 Key: CB-11281
>                 URL: https://issues.apache.org/jira/browse/CB-11281
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>    Affects Versions: 3.5.0
>         Environment: Windows 10
>            Reporter: Kai Schätzl
>            Assignee: Deshan Kalupahana
>            Priority: Minor
>              Labels: Windows, easy, easyfix, triaged, windows-universal
>             Fix For: Master
>
>
> Consider the case where you have a defaultText for navigator.notification.prompt, the
user sees it and then hits enter.
> With the original Javascript prompt dialog you get whatever's in the field as output.
var result = prompt ("Description", "Default Value");
> So, if the user enters nothing you get the default value given as your value in result.
> This is the expected behavior when mimicking this dialog.
> To my surprise, this is not what happens with navigator.notification.prompt. If the user
enters nothing then nothing is returned via results.input1. Although it looks like something
is already "sitting" there and waiting for submit.
> I think this behavior should be changed according to what the Javascript prompt dialog
does. That makes it consistent with browser behavior and what most people expect.
> This bug might be related to https://issues.apache.org/jira/browse/CB-11214, where the
reporter seems to expect the opposite (not sure about that).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message