cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11085) AudioHandler logs should use system log, not println
Date Wed, 24 Aug 2016 06:49:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434287#comment-15434287
] 

ASF GitHub Bot commented on CB-11085:
-------------------------------------

GitHub user sanjeewa894 reopened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/110

    CB-11085 (Android) Fixed AudioHandler logs should use system log, not println

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    This is a fix for https://issues.apache.org/jira/browse/CB-11085.
    It fixes the println to LOG (android.util.Log use in org.apache.cordova.LOG).
    
    ### What testing has been done on this change?
    Testing was unable to do.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjeewa894/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----
commit 9084576e1a6853c82457e2d379fb3d2a0e3364f6
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date:   2016-08-23T17:44:29Z

    Fix error output using println to Log.e

commit fac888da1b8cf88eb1fc44ac3a0e94b6d0030dbb
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date:   2016-08-23T17:46:05Z

    Merge remote-tracking branch 'origin/master'

commit c1c01b1834e1a37158b6de247ac444a1d49fbdbf
Author: sanjeewa894 <sanjeewaapp@gmail.com>
Date:   2016-08-23T17:53:12Z

    Fix error output using println to LOG.e

----


> AudioHandler logs should use system log, not println
> ----------------------------------------------------
>
>                 Key: CB-11085
>                 URL: https://issues.apache.org/jira/browse/CB-11085
>             Project: Apache Cordova
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin Media
>    Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0, 1.6.1, 1.7.0, 1.8.0,
1.8.1, 1.9.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.8.0, 2.9.0, 3.0.0,
3.1.0, 3.2.0, 3.3.0, 3.4.0, 2.9.1, 3.5.0
>            Reporter: Fabrice Lebas
>            Assignee: sanjeewa kumara
>            Priority: Minor
>              Labels: Android, easyfix, test
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> AudioHandler.java should use android.util.Log rather than println.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message