cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11074) WKWebView configuration is not considered
Date Wed, 03 Aug 2016 23:11:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406792#comment-15406792
] 

ASF GitHub Bot commented on CB-11074:
-------------------------------------

Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7
  
    I have failing unit tests that do objectively verify that as others have shown, yes, we
can't update the configuration dynamically (I've tried all sorts of clever runtime tricks,
to no avail).
    
     The WKWebViewConfiguration.preferences (WKPreferences) *can* however be updated dynamically.
I will update https://issues.apache.org/jira/browse/CB-11496 with the unit tests to reflect
this, as well as document this. After doing so, I will re-review this pull request with that
in mind.
    



> WKWebView configuration is not considered
> -----------------------------------------
>
>                 Key: CB-11074
>                 URL: https://issues.apache.org/jira/browse/CB-11074
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin WKWebViewEngine
>         Environment: ios
>            Reporter: Alexis Kofman
>            Assignee: Shazron Abdullah
>            Priority: Critical
>              Labels: ios, triaged
>
> Regarding the code of WKWebView.h, WKWebViewConfiguration seems to be a readonly property.
> {code}
> @property (nonatomic, readonly, copy) WKWebViewConfiguration *configuration;
> {code}
> But in this plugin, we are trying to update the WKWebView configuration after initialising
it and it looks like all this part is not considered :
> https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L146-L150



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message