cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10467) Hardware back button, while InAppBrowser is opened, closes the app too in addition to closing InAppBrowser
Date Tue, 16 Aug 2016 17:18:20 GMT

    [ https://issues.apache.org/jira/browse/CB-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423089#comment-15423089
] 

ASF GitHub Bot commented on CB-10467:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/178

    CB-10467 Hardware back button, while InAppBrowser is opened, closes t…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    …he app too in addition to closing InAppBrowser
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-10467)
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Adds the same backbutton handling behavior to Windows as Android platform has, i.e. if
`hardwareback=yes` (by default) we navigate history back and then close inappbrowser, and
just close iab if `hardwareback=no`.
    
    ### What testing has been done on this change?
    Tested on Windows 8.1/10 and Phone 8.1/10.
    backbutton event is not fired in a Windows 8.1 project on Windows 10 host OS; otherwise
all works ok.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10467

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 3f180ffa96ac345384e31fd52a479517a14f4000
Author: daserge <v-seshak@microsoft.com>
Date:   2016-08-16T17:10:15Z

    CB-10467 Hardware back button, while InAppBrowser is opened, closes the app too in addition
to closing InAppBrowser

----


> Hardware back button, while InAppBrowser is opened, closes the app too in addition to
closing InAppBrowser
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CB-10467
>                 URL: https://issues.apache.org/jira/browse/CB-10467
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>    Affects Versions: 1.2.0
>         Environment: Windows phone 8.1
>            Reporter: Sam Deepak
>            Assignee: Sergey Shakhnazarov
>              Labels: cordova, inappbrowser, reproduced, triaged, wfc, windows, wp8
>
> The hardware back button when tapped closes the app (puts in background mode) in addition
to closing the InAppBrowser.
> This behavior exists in windows phone only whereas it works fine in Android (it closes
only the InAppBrowser).
> Please help me fix this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message