cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6708) iOS does not preserve GPS metadata from images picked from the Photo Gallery
Date Wed, 24 Aug 2016 22:19:21 GMT

    [ https://issues.apache.org/jira/browse/CB-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435832#comment-15435832
] 

ASF GitHub Bot commented on CB-6708:
------------------------------------

Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/230#discussion_r76150053
  
    --- Diff: src/ios/CDVCamera.m ---
    @@ -240,13 +240,9 @@ - (void)alertView:(UIAlertView *)alertView clickedButtonAtIndex:(NSInteger)butto
     
     - (void)repositionPopover:(CDVInvokedUrlCommand*)command
     {
    -    if (([[self pickerController] pickerPopoverController] != nil) && [[[self
pickerController] pickerPopoverController] isPopoverVisible]) {
    +    NSDictionary* options = [command argumentAtIndex:0 withDefault:nil];
    --- End diff --
    
    Hi.
    Thanks for the PR.
    
    I think you forked you repo before this changes were made and didn't sync before sending
your PR, but this code is important to fix another bug.
    Can you make sure that your fork is in sync with the latest code on this repo and then
send the PR with just the relevant code to fix the issue?


> iOS does not preserve GPS metadata from images picked from the Photo Gallery
> ----------------------------------------------------------------------------
>
>                 Key: CB-6708
>                 URL: https://issues.apache.org/jira/browse/CB-6708
>             Project: Apache Cordova
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Plugin Camera
>            Reporter: Ryan Murphy
>            Priority: Minor
>              Labels: Triaged, camera, gps, ios
>
> Images picked from the gallery do not preserve metadata when saved to tmp. Particularly
they lose GPS metadata.
> This extra metadata is available in asset.defaultRepresentation.metadata. 
> I have a solution that works for my purpose. But currently only saving with asset.defaultRepresentation.fullResolutionImage.
> Approach to get the asset: https://github.com/foundry/UIImageMetadata
> Approach to save the asset: http://stackoverflow.com/a/15398387/618412 (answer from Andrew
Theis).
> Thanks for consideration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message