cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1
Date Tue, 16 Aug 2016 16:47:20 GMT

    [ https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423022#comment-15423022
] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user danbucholtz opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15

    Ionic changes to WKWebView (For Code Review only)

    As of August 16th, 2016, this is not ready to be merged.  I am just creating this PR to
facilitate dialogue and chat about the changes.
    
    Thanks,
    Dan
    
    
    ### Platforms affected
    
    iOS
    
    
    ### What does this PR do?
    
    Resolves some DOM exceptions and XHR challenges with WKWebView
    
    ### What testing has been done on this change?
    
    We have tested it manually on iOS 9 and iOS 10 across several different Cordova apps.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/driftyco/cordova-plugin-wkwebview-engine master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 16abc046c64e5bc28c61d27464e2d6b38ea31d18
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-06-30T14:38:29Z

    XHR works in WKWebView 🎉

commit c7039ffd02804bf5909b972a3be2d1e9d2eed200
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-06-30T23:03:41Z

    Plugin imports xhr.js correctly

commit 380a46358879204a30b15409eabd5e5612c66d5a
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-01T15:02:31Z

    ScrollEnabled is enabled by default

commit d1b9d2ea6a422eecfce0a94336e6c24f9df48964
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-01T21:49:50Z

    Fixes removeEventListener crash

commit 339cc7ce931899c00b7a2d6c66944e261c320a70
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-01T21:50:15Z

    Merge branch 'master' of github.com:manucorporat/cordova-plugin-wkwebview-engine

commit 239c128e517c8a787d4a7bf537eb33c9369057dd
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-07T12:21:02Z

    Refactor XHR + security checks

commit 2b1f34c62704f20bb2500dedcd3105d0b962ca9a
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-07T13:51:41Z

    Adds XHR polyfill was not found warning

commit f37ce29bc56930daa723530069a4d0a367978352
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-07T13:54:47Z

    Updated Plugin's version

commit 6927cf808cca5d631c1e8d95bd5f0c51556931dd
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-07-08T19:34:35Z

    Fixes DOM security exceptions in iOS 10

commit 041bb8b470eadff5141f10e64de7dfb06dcd9d48
Author: Manu Mtz.-Almeida <manu.valladolid@gmail.com>
Date:   2016-08-14T19:34:24Z

    Merge branch 'master' of github.com:driftyco/cordova-plugin-wkwebview-engine

commit dcbed50a7678f44d5cd7bc6e26e0ab35bc226e15
Author: Dan Bucholtz <dan.bucholtz@gmail.com>
Date:   2016-08-16T15:06:04Z

    ionic readme

commit 3545c5735133954ce5e46ab0f328d8fe64f09b3b
Author: Adam Bradley <adamdbradley@users.noreply.github.com>
Date:   2016-08-16T15:21:53Z

    Update README.md

commit fe6e87e904252823b560e5ea5450437765599c6c
Author: Dan Bucholtz <dan.bucholtz@gmail.com>
Date:   2016-08-16T15:23:48Z

    typo fix

commit ac93b144117def76ff34820e2f924bebcf28d749
Author: Dan Bucholtz <dan.bucholtz@gmail.com>
Date:   2016-08-16T15:32:14Z

    include more of the original readme details

commit 43da5a7c50ad776efd77d34d0d8deb7c0a1fa203
Author: Dan Bucholtz <dan.bucholtz@gmail.com>
Date:   2016-08-16T15:37:51Z

    limitations

commit 20d06b85e6ea1cad6621b780268f3b27e8a1d2ab
Author: Dan Bucholtz <dan.bucholtz@gmail.com>
Date:   2016-08-16T15:38:56Z

    limitations

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry, CLI
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating BlackBerry
project...
> Updating config.xml ...
> sed: /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message