Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 836BD200B45 for ; Fri, 1 Jul 2016 03:22:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 82294160A63; Fri, 1 Jul 2016 01:22:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EFDA6160A52 for ; Fri, 1 Jul 2016 03:22:11 +0200 (CEST) Received: (qmail 23328 invoked by uid 500); 1 Jul 2016 01:22:11 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 23313 invoked by uid 99); 1 Jul 2016 01:22:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 01:22:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0474F2C02A3 for ; Fri, 1 Jul 2016 01:22:11 +0000 (UTC) Date: Fri, 1 Jul 2016 01:22:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9371) Prepare deletes orientation preferences MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 01 Jul 2016 01:22:12 -0000 [ https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358197#comment-15358197 ] ASF GitHub Bot commented on CB-9371: ------------------------------------ Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 Thanks, @shazron. I've rebased this pr and opened a new one here https://github.com/apache/cordova-ios/pull/233 > Prepare deletes orientation preferences > --------------------------------------- > > Key: CB-9371 > URL: https://issues.apache.org/jira/browse/CB-9371 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaLib > Affects Versions: 5.1.1 > Reporter: Connor Pearson > Assignee: Shazron Abdullah > > If a user does not have a orientation preference defined in config.xml then running prepare will delete all orientation preferences in their info.plist. > I'd expect prepare to overwrite the values if the user chose an orientation preferences, otherwise it should respect the values that are already there. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org