cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-11643) Crash when file request is forbidden
Date Fri, 29 Jul 2016 14:19:20 GMT


ASF GitHub Bot commented on CB-11643:

GitHub user cjpearson opened a pull request:

    CB-11643: return after sending error

    ### Platforms affected
    ### What does this PR do?
    After an error is returned, we should return and not process the request. Continuing to
process the request can cause a crash.
    ### What testing has been done on this change?
    Tested on a device with the sample app, adding the following code.
    document.getElementById("deviceready").addEventListener("click", function buttonClick()
                var fail = function () { console.log("failure"); }
                var photoSuccess = function (uri) {
                    var img = document.createElement("img");
                    img.src = uri;
      , fail, {
                            saveToPhotoAlbum: false
    ### Checklist
    - [X] [ICLA]( has been signed and submitted to
    - [X] [Reported an issue]( in the JIRA
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull webserver-crash

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
commit 2568693862556a712fdf760487a9d3f6f0ffb5f9
Author: Connor Pearson <>
Date:   2016-07-29T14:15:01Z

    CB-11643: return after sending error


> Crash when file request is forbidden
> ------------------------------------
>                 Key: CB-11643
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Labs, Plugin WKWebViewEngine
>            Reporter: Connor Pearson
>            Assignee: Shazron Abdullah
> When loading an image without the token cookie a 403 error is returned. The request is
still processed though and causes the web server to crash.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message