cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11572) Removing plugins doesn't remove their gradle configuration
Date Thu, 14 Jul 2016 07:37:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376501#comment-15376501
] 

Vladimir Kotikov commented on CB-11572:
---------------------------------------

[~jfrumar], thank you for reporting. I have investigated the problem and found that it happens
due to incorrect logic in plugin's {{before_plugin_uninstall}} hook. Presumably [this line|https://github.com/sarriaroman/FabricPlugin/blob/master/hooks/lib/android-helper.js#L34]
is to blame.

I'm closing this issue - please report this problem to plugin's maintainers

> Removing plugins doesn't remove their gradle configuration
> ----------------------------------------------------------
>
>                 Key: CB-11572
>                 URL: https://issues.apache.org/jira/browse/CB-11572
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.2.0
>            Reporter: Julian Frumar
>              Labels: reproduced, triaged
>
> We use the Craslytics (Fabric) plugin in production builds, but in our dev environment
we remove the plugin.
> Unfortunately, running `cordova plugin rm cordova-fabric-plugin` leaves around its (now
stale) configuration in build.gradle.
> Steps to reproduce:
> - Install the fabric plugin (or any plugin that has a gradle config): `cordova plugin
add https://github.com/sarriaroman/FabricPlugin.git --variable FABRIC_API_KEY=foo --variable
FABRIC_API_SECRET=bar`
> - Check your build.gradle. For this particular plugin you'll see at the bottom of your
file: 
> {code}
> buildscript {
>     repositories {
>         maven { url 'https://maven.fabric.io/public' }
>     }
>     dependencies {
>         classpath 'io.fabric.tools:gradle:1.+'
>     }
> }
> apply plugin: 'io.fabric'
> // Fabric Cordova Plugin - End Fabric Build Tools
> {code}
> - Remote the plugin with `cordova plugin rm cordova-fabric-plugin`
> - Inspect your build.gradle file again, and you'll still find that existing config at
the bottom of the file.
> This breaks our development builds.
> Also, if you now go ahead and re-install, you'll see the gradle config has been appended
twice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message