cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Frumar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CB-11572) Removing plugins doesn't remove their gradle configuration
Date Wed, 13 Jul 2016 19:44:20 GMT

     [ https://issues.apache.org/jira/browse/CB-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Julian Frumar updated CB-11572:
-------------------------------
    Description: 
We use the Craslytics (Fabric) plugin in production builds, but in our dev environment we
remove the plugin.

Unfortunately, running `cordova plugin rm cordova-fabric-plugin` leaves around its (now stale)
configuration in build.gradle.

Steps to reproduce:

- Install the fabric plugin (or any plugin that has a gradle config): `cordova plugin add
https://github.com/sarriaroman/FabricPlugin.git --variable FABRIC_API_KEY=foo --variable FABRIC_API_SECRET=bar`

- Check your build.gradle. For this particular plugin you'll see at the bottom of your file:

{code}
buildscript {
    repositories {
        maven { url 'https://maven.fabric.io/public' }
    }
    dependencies {
        classpath 'io.fabric.tools:gradle:1.+'
    }
}

apply plugin: 'io.fabric'
// Fabric Cordova Plugin - End Fabric Build Tools
{code}

- Remote the plugin with `cordova plugin rm cordova-fabric-plugin`

- Inspect your build.gradle file again, and you'll still find that existing config at the
bottom of the file.

This breaks our development builds.

Also, if you now go ahead and re-install, you'll see the gradle config has been appended twice.

  was:
We use the Craslytics (Fabric) plugin in production builds, but in our dev environment we
remove the plugin.

Unfortunately, running `cordova plugin rm cordova-fabric-plugin` leaves around its (now stale)
configuration in build.gradle.

Steps to reproduce:

- Install the fabric plugin (or any plugin that has a gradle config): `cordova plugin add
https://github.com/sarriaroman/FabricPlugin.git --variable FABRIC_API_KEY=foo --variable FABRIC_API_SECRET=bar`

- Check your build.gradle. For this particular plugin you'll see at the bottom of your file:

{code}
buildscript {
    repositories {
        maven { url 'https://maven.fabric.io/public' }
    }
    dependencies {
        classpath 'io.fabric.tools:gradle:1.+'
    }
}

apply plugin: 'io.fabric'
// Fabric Cordova Plugin - End Fabric Build Tools
{code}

- Remote the plugin with `cordova plugin rm cordova-fabric-plugin`

- Inspect your build.gradle file again, and you'll still find that existing config at the
bottom of the file.

This breaks our development builds.


> Removing plugins doesn't remove their gradle configuration
> ----------------------------------------------------------
>
>                 Key: CB-11572
>                 URL: https://issues.apache.org/jira/browse/CB-11572
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 6.2.0
>            Reporter: Julian Frumar
>
> We use the Craslytics (Fabric) plugin in production builds, but in our dev environment
we remove the plugin.
> Unfortunately, running `cordova plugin rm cordova-fabric-plugin` leaves around its (now
stale) configuration in build.gradle.
> Steps to reproduce:
> - Install the fabric plugin (or any plugin that has a gradle config): `cordova plugin
add https://github.com/sarriaroman/FabricPlugin.git --variable FABRIC_API_KEY=foo --variable
FABRIC_API_SECRET=bar`
> - Check your build.gradle. For this particular plugin you'll see at the bottom of your
file: 
> {code}
> buildscript {
>     repositories {
>         maven { url 'https://maven.fabric.io/public' }
>     }
>     dependencies {
>         classpath 'io.fabric.tools:gradle:1.+'
>     }
> }
> apply plugin: 'io.fabric'
> // Fabric Cordova Plugin - End Fabric Build Tools
> {code}
> - Remote the plugin with `cordova plugin rm cordova-fabric-plugin`
> - Inspect your build.gradle file again, and you'll still find that existing config at
the bottom of the file.
> This breaks our development builds.
> Also, if you now go ahead and re-install, you'll see the gradle config has been appended
twice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message