cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11522) Do not clone the detail object on activation context
Date Wed, 06 Jul 2016 15:28:11 GMT

    [ https://issues.apache.org/jira/browse/CB-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364464#comment-15364464
] 

ASF GitHub Bot commented on CB-11522:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-js/pull/134

    CB-11522 Do not clone the detail object on activation context

    Fix clone method so that it does not crash trying to clone unavailable property
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-11522)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-js CB-11522

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit 886843febcc34d7248dfd968fde2e00a34c9be29
Author: daserge <v-seshak@microsoft.com>
Date:   2016-07-06T15:26:52Z

    CB-11522 Do not clone the detail object on activation context
    
    Fix clone method so that it does not crash trying to clone unavailable property

----


> Do not clone the detail object on activation context
> ----------------------------------------------------
>
>                 Key: CB-11522
>                 URL: https://issues.apache.org/jira/browse/CB-11522
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Daniel Toplak
>            Assignee: Sergey Shakhnazarov
>            Priority: Blocker
>              Labels: reproduced, triaged, windows
>
> In some circumstances, cloning the detail object of the activation context will fail.
Esp. when launching the app via ActivationKind.file.
> The cloning of the detail object was introduced in https://issues.apache.org/jira/browse/CB-10653
> See: https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message