cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-11516) Preparing fails on icons with a target
Date Fri, 08 Jul 2016 13:12:11 GMT


ASF GitHub Bot commented on CB-11516:

GitHub user vladimir-kotikov opened a pull request:

    CB-11516 windows: Preparing icons w/ target fails

    This closes #179

You can merge this pull request into a Git repository by running:

    $ git pull CB-11548

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #184
commit f6f7f89a5be4a2efac0fa19538f474095f020f1e
Author: Cody Hoover <>
Date:   2016-06-30T07:30:03Z

    CB-11516 windows: Preparing icons w/ target fails
    This closes #179


> Preparing fails on icons with a target
> --------------------------------------
>                 Key: CB-11516
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 4.4.0
>            Reporter: Cody Hoover
> Putting the following line in the config will will cause an error: "Source directory
does not exist: Square44x44Logo_100.scale"
> <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory information was
lost. `copyMrtImage` in an earlier commit preserved this information (shown in the link below),
but it was lost in a refactoring.
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually only returns
an array of the filenames. This caused the `copyIcons` spec to pass but the code failed when
> I have a fix ready for github.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message