cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (JIRA)" <>
Subject [jira] [Closed] (CB-11516) Preparing fails on icons with a target
Date Mon, 04 Jul 2016 16:40:11 GMT


Vladimir Kotikov closed CB-11516.
    Resolution: Fixed

> Preparing fails on icons with a target
> --------------------------------------
>                 Key: CB-11516
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 4.4.0
>            Reporter: Cody Hoover
> Putting the following line in the config will will cause an error: "Source directory
does not exist: Square44x44Logo_100.scale"
> <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory information was
lost. `copyMrtImage` in an earlier commit preserved this information (shown in the link below),
but it was lost in a refactoring.
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually only returns
an array of the filenames. This caused the `copyIcons` spec to pass but the code failed when
> I have a fix ready for github.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message