cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11516) Preparing fails on icons with a target
Date Mon, 04 Jul 2016 16:37:11 GMT

    [ https://issues.apache.org/jira/browse/CB-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361564#comment-15361564
] 

ASF GitHub Bot commented on CB-11516:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-windows/pull/179


> Preparing fails on icons with a target
> --------------------------------------
>
>                 Key: CB-11516
>                 URL: https://issues.apache.org/jira/browse/CB-11516
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 4.4.0
>            Reporter: Cody Hoover
>
> Putting the following line in the config will will cause an error: "Source directory
does not exist: Square44x44Logo_100.scale"
> <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory information was
lost. `copyMrtImage` in an earlier commit preserved this information (shown in the link below),
but it was lost in a refactoring.
> https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually only returns
an array of the filenames. This caused the `copyIcons` spec to pass but the code failed when
used.
> I have a fix ready for github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message