cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11305) use cdvfile: cannot import image or js
Date Tue, 05 Jul 2016 12:30:11 GMT

    [ https://issues.apache.org/jira/browse/CB-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362420#comment-15362420
] 

ASF GitHub Bot commented on CB-11305:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/186

    CB-11305 Enable cdvfile: assets fs root for DOM requests

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    * Added test for cdvfile applicationDirectory fs root
    * Updated the docs and added the assets to Android available fs roots list
    * Allow cdvfile: access for android automatically
    
    ### What testing has been done on this change?
    Jasmine auto and manual tests, app tests (see [Jira](https://issues.apache.org/jira/browse/CB-11305))
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-file CB-11305

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit 2cdccb7f4734365d9840667359c7c5502b0038f4
Author: daserge <v-seshak@microsoft.com>
Date:   2016-07-05T12:27:21Z

    CB-11305 Enable cdvfile: assets fs root for DOM requests
    
    Added test for cdvfile applicationDirectory fs root
    Updated the docs and added the assets to Android available fs roots list
    Allow cdvfile: access for android automatically

----


> use cdvfile: cannot import image or js
> --------------------------------------
>
>                 Key: CB-11305
>                 URL: https://issues.apache.org/jira/browse/CB-11305
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>    Affects Versions: 6.2.0
>         Environment: cordova 6.6.1
> android 5.1.1
>            Reporter: zhuisui
>              Labels: android, reproduced, triaged, wfc
>
> I use cdvfile://localhost/assets/path to show img and import js, and it doesn't work.
I haven't seen anything about using with assets, but window.resolveLocalFileSystemURL can
handle it to native URL file:///android_asset/path, so I think it should be normal as expected.
> And I didn't test about cdvfile://localhost/temporary|persistent.
> And, I use cordova-cli 6.6.1, but it is not in "Affects Version/s".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message