cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11287) iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed
Date Mon, 04 Jul 2016 22:15:11 GMT

    [ https://issues.apache.org/jira/browse/CB-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361799#comment-15361799
] 

ASF GitHub Bot commented on CB-11287:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/61

    CB-11287: (ios) - fix webview resize after modal on iPhones

    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes CB-11287
    
    ### What testing has been done on this change?
    Tested on iPhones, presenting a modal (camera picker) on landscape mode and dismissing
it.
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar CB-11287-ios-statusbar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 86cfafeaf9796c45c855fc55c3605aadb713af62
Author: Julio C├ęsar <jcesarmobile@gmail.com>
Date:   2016-07-04T22:12:20Z

    CB-11287: (ios) - fix webview resize after modal on iPhones

----


> iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed
> ---------------------------------------------------------------------------------------
>
>                 Key: CB-11287
>                 URL: https://issues.apache.org/jira/browse/CB-11287
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Statusbar
>    Affects Versions: 2.2.0
>         Environment: cordova 6.1.1
> ios 4.1.1
> cordova-plugin-camera 2.2.0 "Camera"
>            Reporter: Michael Schmidt
>            Assignee: jcesarmobile
>              Labels: iOS
>
> *situation*
> * app in landscape mode
> {code:JavaScript}
>   <preference name="Orientation" value="landscape" />
> {code}
> * camera options
> {code:JavaScript}
> {
>  destinationType: Camera.DestinationType.FILE_URI,
>  sourceType: Camera.PictureSourceType.CAMERA,
>  encodingType: Camera.EncodingType.JPEG,
>  mediaType: Camera.MediaType.PICTURE,
> };
> {code}
> *problem*
> After displaying the camera, the app viewport turns to portrait mode - despite that the
whole app is set to landscape.
> This takes place for either taking a picture or pressing cancel.
> This bug occurs only on iPhone, it works on iPad though.
> *appearance*
> the bug (viewport turns portrait) appears in all combinations of 
> - holding phone in portrait/landscape
> - setting correctOrientation to true/false
> - using Camera.PictureSourceType.PHOTOLIBRARY/Camera.PictureSourceType.CAMERA
> *possibly related*
> this error occurs after closing the camera picker:
> {code}
> 2016-06-04 16:38:37.527 CordovaApp[2217:1174793] Warning: Attempt to present <CDVCameraPicker:
0x13ea7aa00> on <MainViewController: 0x13de3ffe0> whose view is not in the window
hierarchy!
> {code}
> *regression from camera 1.2.0*
> This is a regression - it works reproducably in the following configuration:
> {code}
> cordova 5.3.3
> cordova-ios 3.9.1
> cordova-plugin-camera 1.2.0
> {code}
> it slowly degraded: with cordova-plugin-camera 2.0.0 it showed wrong - but still still
could changed by rotating the phone back and forth. With cordova-plugin-camera 2.0.0 the actual
phone orientation makes a difference when correctOrientation is set to true - it seems that
the bug occurs only when the phone is held in portrait during the camera open
> -> seems to be related to correctOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message