cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11241) File encoding test fails with UTF-8 file encoding error on windows store submission
Date Tue, 19 Jul 2016 07:11:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383696#comment-15383696
] 

ASF GitHub Bot commented on CB-11241:
-------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-windows/pull/187

    CB-11241 Return adding BOM to www back to prepare

    This PR reverts changes, made in #134
    
    The reason of reverting is that original change causes the problems with submitting apps
to Windows store when app is built using Visual Studio.
    
    For more background see JIRA issue [CB-11241](https://issues.apache.org/jira/browse/CB-11241)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-windows CB-11241

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 7320b38bab131c3af4e49d4f14a0472c2a3682b6
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2016-07-19T07:02:54Z

    CB-11241 Return adding BOM to www back to prepare

----


> File encoding test fails with UTF-8 file encoding error on windows store submission
> -----------------------------------------------------------------------------------
>
>                 Key: CB-11241
>                 URL: https://issues.apache.org/jira/browse/CB-11241
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 4.4.0, 4.4.1
>            Reporter: Michael Schmidt
>              Labels: triaged
>
> File encoding test
> ```
> FAILED
> UTF-8 file encoding
> Error Found: The UTF-8 file encoding test detected the following errors:
> File www\cordova_plugins.js is not properly UTF-8 encoded. Re-save the file as UTF-8
(including Byte Order Mark).
> File www\cordova-js-src\exec.js is not properly UTF-8 encoded. Re-save the file as UTF-8
(including Byte Order Mark).
> File www\cordova-js-src\platform.js is not properly UTF-8 encoded. Re-save the file as
UTF-8 (including Byte Order Mark).
> File www\js\app.js is not properly UTF-8 encoded. Re-save the file as UTF-8 (including
Byte Order Mark).
> File www\js\libs.js is not properly UTF-8 encoded. Re-save the file as UTF-8 (including
Byte Order Mark).
> File www\plugins\cordova-plugin-console\www\console-via-logger.js is not properly UTF-8
encoded. Re-save the file as UTF-8 (including Byte Order Mark).
> ...
> Impact if not fixed: HTML, CSS, and JavaScript files must be encoded in UTF-8 form with
a corresponding byte-order mark (BOM) in order to benefit from bytecode caching and to avoid
other runtime error conditions.
> How to fix: Open the affected file, and select "Save As..." option from the File menu
in Visual Studio. Select the drop-down control next to the Save button and select "Save with
Encoding..." option. From the Advanced save options dialog, choose the "Unicode (UTF-8 with
signature)" option and click the OK button.
> ````



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message