cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11078) Empty string for BackgroundColor preference crashes application
Date Wed, 13 Jul 2016 07:42:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374539#comment-15374539
] 

ASF GitHub Bot commented on CB-11078:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-android/pull/316
  
    ## [Current coverage][cc-pull] is **33.85%**
    > Merging [#316][cc-pull] into [master][cc-base-branch] will not change coverage
    
    ```diff
    @@             master       #316   diff @@
    ==========================================
      Files            11         11          
      Lines           960        960          
      Methods         197        197          
      Messages          0          0          
      Branches        156        156          
    ==========================================
      Hits            325        325          
      Misses          635        635          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [39165a8...f4a1956][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/cordova-android/compare/39165a8694a35b58f0321fe283f90704e4af1dc1...f4a1956f0e66e61032a9179b4894a652e9717e96?src=pr
    [cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/316?src=pr


> Empty string for BackgroundColor preference crashes application
> ---------------------------------------------------------------
>
>                 Key: CB-11078
>                 URL: https://issues.apache.org/jira/browse/CB-11078
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>         Environment: HTC One
> Android 6.0
> Cordova-Android 5.1.0
>            Reporter: Ryan Willoughby
>            Assignee: Joe Bowser
>            Priority: Minor
>              Labels: easyfix, triaged
>
> A preference of 
> {{<preference name="BackgroundColor" value="" />}}
> will cause an a cordova application to crash on startup with a NumberFormatException:
> {color:red}
> 04-13 11:18:29.894: E/AndroidRuntime(20224): java.lang.RuntimeException: Unable to start
activity ComponentInfo{com.whatever.whatever/com.whatever.whatever.ClassName}: java.lang.NumberFormatException:
Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2484)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2544)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.ActivityThread.access$900(ActivityThread.java:150)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1394)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.os.Handler.dispatchMessage(Handler.java:102)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.os.Looper.loop(Looper.java:168)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.ActivityThread.main(ActivityThread.java:5845)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at java.lang.reflect.Method.invoke(Native
Method)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:797)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:687)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): Caused by: java.lang.NumberFormatException:
Invalid long: ""
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at java.lang.Long.invalidLong(Long.java:124)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at java.lang.Long.decode(Long.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at org.apache.cordova.CordovaPreferences.getInteger(CordovaPreferences.java:78)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at org.apache.cordova.CordovaActivity.createViews(CordovaActivity.java:178)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at org.apache.cordova.CordovaActivity.init(CordovaActivity.java:142)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at org.apache.cordova.CordovaActivity.loadUrl(CordovaActivity.java:214)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at uk.directpath.staffssmartalert2.StaffsSmartAlertv2.onCreate(StaffsSmartAlertv2.java:32)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.Activity.performCreate(Activity.java:6248)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1125)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2437)
> 04-13 11:18:29.894: E/AndroidRuntime(20224): 	... 9 more
> {color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message