cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9371) Prepare deletes orientation preferences
Date Fri, 01 Jul 2016 00:38:10 GMT

    [ https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358111#comment-15358111
] 

ASF GitHub Bot commented on CB-9371:
------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-ios/pull/233

    CB-9371, CB-9703: Fix how prepare handles orientation on ios

    Relates to https://github.com/apache/cordova-lib/pull/260
    
    This changes the behavior of the default orientation preference to match the default orientation
settings for new native iOS projects.
    
    It also no longer modifies the orientation settings if the user does not specify an orientation
preference.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-ios CB-9371

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #233
    
----
commit 55b0a26fb2ba4186273d98fb3adcee205b2fb632
Author: Connor Pearson <cjp822@gmail.com>
Date:   2016-07-01T00:27:12Z

    CB-9371: Fix how prepare handles orientation on ios

----


> Prepare deletes orientation preferences
> ---------------------------------------
>
>                 Key: CB-9371
>                 URL: https://issues.apache.org/jira/browse/CB-9371
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.1.1
>            Reporter: Connor Pearson
>            Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then running prepare
will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation preferences,
otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message