cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9371) Prepare deletes orientation preferences
Date Fri, 01 Jul 2016 01:35:11 GMT

    [ https://issues.apache.org/jira/browse/CB-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358201#comment-15358201
] 

ASF GitHub Bot commented on CB-9371:
------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-ios/pull/233
  
    ## [Current coverage][cc-pull] is **51.81%**
    > Merging [#233][cc-pull] into [master][cc-base-branch] will not change coverage
    
    ```diff
    @@             master       #233   diff @@
    ==========================================
      Files            11         11          
      Lines           882        882          
      Methods         132        132          
      Messages          0          0          
      Branches        143        143          
    ==========================================
      Hits            457        457          
      Misses          425        425          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [3d80c24...4d792db][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/cordova-ios/compare/3d80c24a594b4d43a368fa278a23218a3f17310f...4d792dba84a23866b2ab1850e49a921bacf82ba0
    [cc-pull]: https://codecov.io/gh/apache/cordova-ios/pull/233?src=pr


> Prepare deletes orientation preferences
> ---------------------------------------
>
>                 Key: CB-9371
>                 URL: https://issues.apache.org/jira/browse/CB-9371
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.1.1
>            Reporter: Connor Pearson
>            Assignee: Shazron Abdullah
>
> If a user does not have a orientation preference defined in config.xml then running prepare
will delete all orientation preferences in their info.plist.
> I'd expect prepare to overwrite the values if the user chose an orientation preferences,
otherwise it should respect the values that are already there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message