cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-8947) alert() crashes when passing a JSON object on iOS
Date Thu, 28 Jul 2016 19:13:20 GMT


ASF GitHub Bot commented on CB-8947:

GitHub user don opened a pull request:

    CB-8947: (ios) 

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Fix crash when non-strings are passed to dialogs
    ### What testing has been done on this change?
    Added manual tests to plugin
    ### Checklist
    - [x] [ICLA]( has been signed and submitted to
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-8947

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #80


> alert() crashes when passing a JSON object on iOS
> -------------------------------------------------
>                 Key: CB-8947
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>    Affects Versions: 4.0.0
>         Environment: Notifications Plugin version 0.3.0
>            Reporter: Dennis Patzer
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> In the error handler of a geolocation retrieval I had alert(error); which crashes, because
I passed an object into the function call. This shouldn't happen.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message