Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 115E7200B29 for ; Thu, 16 Jun 2016 00:36:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0FE7C160A57; Wed, 15 Jun 2016 22:36:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 586C8160A4D for ; Thu, 16 Jun 2016 00:36:15 +0200 (CEST) Received: (qmail 87441 invoked by uid 500); 15 Jun 2016 22:36:09 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 87359 invoked by uid 99); 15 Jun 2016 22:36:09 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jun 2016 22:36:09 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6717C2C1F5D for ; Wed, 15 Jun 2016 22:36:09 +0000 (UTC) Date: Wed, 15 Jun 2016 22:36:09 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-11412) Update template implementation in cordova create --template MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Jun 2016 22:36:16 -0000 [ https://issues.apache.org/jira/browse/CB-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15332769#comment-15332769 ] ASF GitHub Bot commented on CB-11412: ------------------------------------- Github user stevengill commented on the issue: https://github.com/apache/cordova-app-hello-world/pull/16 Lets update version in the default config.xml to be 1.0.0 instead of 0.0.1 > Update template implementation in cordova create --template > ----------------------------------------------------------- > > Key: CB-11412 > URL: https://issues.apache.org/jira/browse/CB-11412 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaLib > Reporter: Caryn Tran > Assignee: Caryn Tran > > https://github.com/cordova/cordova-discuss/pull/49 > Sometimes we do want a `package.json` copied over. `package.json` could have build scripts that are essential for the template to work. To handle this use case, template authors are suggested to put template files in a subdirectory and point to that subdirectory in index.js. All files in the subdirectory are copied over. > Update the current template implementation to ignore the list of files above that shouldn't be copied over when using `--template`. If a subdirectory is used, copy the entire contents of the subdirectory. > If a `package.json` exists in the subdirectory, we should update its fields like we do to `config.xml`. https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382. Only field to update in `package.json` should be `package.name`. `package.name` should be updated to use `config.name` lowercased (npm package names have to be lowercase). `config.name` is the optional third argument `cordova create` takes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org