Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E4A51200B0F for ; Fri, 3 Jun 2016 02:07:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3301160A52; Fri, 3 Jun 2016 00:07:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 33E68160A51 for ; Fri, 3 Jun 2016 02:07:00 +0200 (CEST) Received: (qmail 1199 invoked by uid 500); 3 Jun 2016 00:06:59 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 1186 invoked by uid 99); 3 Jun 2016 00:06:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 00:06:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 389282C1F5C for ; Fri, 3 Jun 2016 00:06:59 +0000 (UTC) Date: Fri, 3 Jun 2016 00:06:59 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-11352) WKWebView doesn't apply User-Agent configuration MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 03 Jun 2016 00:07:01 -0000 [ https://issues.apache.org/jira/browse/CB-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313353#comment-15313353 ] ASF GitHub Bot commented on CB-11352: ------------------------------------- Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/225 The lines I quoted show the descriptions of what failed - you don't need to touch the tests, just fix your code. The tests run on the standard UIWebView, not WKWebView, and must pass before any PR is accepted. In any case, in iOS 9, there is a "customUserAgent" property for WKWebView that should be set instead: https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKWebView_Ref/#//apple_ref/occ/instp/WKWebView/customUserAgent and not the cordova workaround way. > WKWebView doesn't apply User-Agent configuration > ------------------------------------------------ > > Key: CB-11352 > URL: https://issues.apache.org/jira/browse/CB-11352 > Project: Apache Cordova > Issue Type: Bug > Components: iOS > Affects Versions: 4.1.1 > Reporter: Andreas Kohn > Assignee: Shazron Abdullah > > {{config.xml}} contains > {code} > > {code} > This is properly used for Android (cordova-android 5.1.1), but not with iOS+WKWebView (cordova-ios 4.1.1). > The cause is actually "documented": CDVUserAgentUtil:setUserAgent says that the default settings must be registered before the webview is actually instantiated. But, CDVViewController:viewDidLoad delays the call to setUserAgent until after the view has been created. > AFAIR this worked with the UIWebView. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org