cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11412) Update template implementation in cordova create --template
Date Tue, 14 Jun 2016 00:04:57 GMT

    [ https://issues.apache.org/jira/browse/CB-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328666#comment-15328666
] 

ASF GitHub Bot commented on CB-11412:
-------------------------------------

GitHub user carynbear opened a pull request:

    https://github.com/apache/cordova-lib/pull/456

    CB-11412 improve template implementation

    Removed symlinking.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carynbear/cordova-lib CB-11412-remove-linking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #456
    
----
commit 5139dee43071c518b9336f69df468824be0c496f
Author: carynbear <caryn.tran@berkeley.edu>
Date:   2016-06-13T21:29:06Z

    CB-11412 improve template implementation

----


> Update template implementation in cordova create --template
> -----------------------------------------------------------
>
>                 Key: CB-11412
>                 URL: https://issues.apache.org/jira/browse/CB-11412
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Caryn Tran
>            Assignee: Caryn Tran
>
> https://github.com/cordova/cordova-discuss/pull/49
> Sometimes we do want a `package.json` copied over. `package.json` could have build scripts
that are essential for the template to work. To handle this use case, template authors are
suggested to put template files in a subdirectory and point to that subdirectory in index.js.
All files in the subdirectory are copied over.
> Update the current template implementation to ignore the list of files above that shouldn't
be copied over when using `--template`. If a subdirectory is used, copy the entire contents
of the subdirectory.
> If a `package.json` exists in the subdirectory, we should update its fields like we do
to `config.xml`. https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
Only field to update in `package.json` should be `package.name`. `package.name` should be
updated to use `config.name` lowercased (npm package names have to be lowercase). `config.name`
is the optional third argument `cordova create` takes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message