cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11412) Update template implementation in cordova create --template
Date Tue, 14 Jun 2016 22:42:30 GMT

    [ https://issues.apache.org/jira/browse/CB-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330796#comment-15330796
] 

ASF GitHub Bot commented on CB-11412:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/456#discussion_r67071311
  
    --- Diff: cordova-lib/spec-cordova/create.spec.js ---
    @@ -121,6 +122,36 @@ describe('create end-to-end', function() {
             // expect(configXml.name()).toEqual('TestBase');
         }
     
    +    function checkSubDir() {
    +        // Check if top level dirs exist.
    +        var dirs = ['hooks', 'platforms', 'plugins', 'www'];
    +        dirs.forEach(function(d) {
    +            expect(path.join(project, d)).toExist();
    +        });
    +        expect(path.join(project, 'hooks', 'README.md')).toExist();
    +        
    +        //index.js and template folder should not exist (inner files should be copied
to the project folder)
    +        expect(path.join(project, 'index.js')).not.toExist();
    +        expect(path.join(project, 'template')).not.toExist();
    --- End diff --
    
    Is this assuming the template folder is named `template`?


> Update template implementation in cordova create --template
> -----------------------------------------------------------
>
>                 Key: CB-11412
>                 URL: https://issues.apache.org/jira/browse/CB-11412
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib
>            Reporter: Caryn Tran
>            Assignee: Caryn Tran
>
> https://github.com/cordova/cordova-discuss/pull/49
> Sometimes we do want a `package.json` copied over. `package.json` could have build scripts
that are essential for the template to work. To handle this use case, template authors are
suggested to put template files in a subdirectory and point to that subdirectory in index.js.
All files in the subdirectory are copied over.
> Update the current template implementation to ignore the list of files above that shouldn't
be copied over when using `--template`. If a subdirectory is used, copy the entire contents
of the subdirectory.
> If a `package.json` exists in the subdirectory, we should update its fields like we do
to `config.xml`. https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/create.js#L378-L382.
Only field to update in `package.json` should be `package.name`. `package.name` should be
updated to use `config.name` lowercased (npm package names have to be lowercase). `config.name`
is the optional third argument `cordova create` takes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message