cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11332) Run core plugins tests on Saucelabs
Date Wed, 01 Jun 2016 09:51:59 GMT

    [ https://issues.apache.org/jira/browse/CB-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310046#comment-15310046
] 

ASF GitHub Bot commented on CB-11332:
-------------------------------------

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/7#discussion_r65332069
  
    --- Diff: lib/paramedic.js ---
    @@ -167,8 +175,55 @@ ParamedicRunner.prototype.writeMedicConnectionUrl = function(url)
{
     
     ParamedicRunner.prototype.runTests = function() {
         var self = this;
    +    if (this.config.shouldUseSauce()) {
    +        var command = this.getCommandForBuilding();
    +        logger.normal('cordova-paramedic: running command ' + command);
    +
    +        return execPromise(command)
    +        .then(this.runSauceTests.bind(this));
    +    } else {
    +        return self.getCommandForStartingTests()
    +        .then(function(command) {
    +        	self.setPermissions();
    +        	logger.normal('cordova-paramedic: running command ' + command);
    +
    +        	return execPromise(command);
    +        })
    +        .then(function(code, output) {
    +            // skip tests if it was just build
    +            if (self.shouldWaitForTestResult()) {
    +                return Q.promise(function(resolve, reject) {
    +                    // reject if timed out
    +                    self.waitForConnection().catch(reject);
    +                    // resolve if got results
    +                    self.waitForTests().then(resolve);
    +                });
    +            }
    +        }, function(code, output) {
    +            // this trace is automatically available in verbose mode
    +            // so we check for this flag to not trace twice
    +            if (!self.config.verbose) {
    --- End diff --
    
    Looks like there is some indentation issues here


> Run core plugins tests on Saucelabs
> -----------------------------------
>
>                 Key: CB-11332
>                 URL: https://issues.apache.org/jira/browse/CB-11332
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: AllPlugins
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>
> Use Appium to deploy the app and gather results via paramedic's tunnel.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message