cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11136) InAppBrowser fails to close with WKWebView OAuth
Date Thu, 30 Jun 2016 15:21:10 GMT

    [ https://issues.apache.org/jira/browse/CB-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357259#comment-15357259
] 

ASF GitHub Bot commented on CB-11136:
-------------------------------------

GitHub user alesveselka opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/171

    CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebVie…

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/saphocom/cordova-plugin-inappbrowser CB-11136

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #171
    
----
commit 714e24595833590bac85fadd1eb32c2f40e0fd53
Author: Ales Veselka <ales@sapho.com>
Date:   2016-06-30T15:18:20Z

    CB-11136: Fix OAuth by preventing InAppBrowser from blocking WKWebView thread

----


> InAppBrowser fails to close with WKWebView OAuth 
> -------------------------------------------------
>
>                 Key: CB-11136
>                 URL: https://issues.apache.org/jira/browse/CB-11136
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser, Plugin WKWebViewEngine
>    Affects Versions: 4.1.0
>         Environment: iOS 8+ with WKWebView
>            Reporter: Geordie Jay
>            Assignee: Shazron Abdullah
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Launching InAppBrowser from Cordova iOS Platform 4+ with its WKWebView for OAuth (e.g.
Facebook or Google login) fails to close as it should.
> The reason is that the entire WKWebView thread seems to pause when another view controller
is presented. This can be confirmed by inspecting the WKWebView session in Safari, running
`window.open('http://something.com')` and then trying to enter another command into that Safari
console.
> I made a hacky but working version of this that animated in the InAppBrowser's view manually,
rather than 'presenting' the ViewController in the traditional iOS style. In that instance
the WKWebView thread continues as normal and receives the confirmation to close the other
InAppBrowser when the OAuth process is complete.
> Maybe there is a better way around this, but at the moment this is a big usability fail
for all WKWebView users.
> What do you all think, is the 'not-actually-presenting' way of presenting the InAppBrowser
acceptable? Would be happy to make a pull request along these lines if it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message