cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7497) Crash on open app from fresh
Date Tue, 21 Jun 2016 10:55:57 GMT

    [ https://issues.apache.org/jira/browse/CB-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341553#comment-15341553
] 

ASF GitHub Bot commented on CB-7497:
------------------------------------

GitHub user hrensink opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/106

    CB-7497: (iOS) Fix bug with application crash

    ### Platforms affected
    iOS 
    
    ### What does this PR do?
    Fix bug with application crash on attempt to remove observers from viewController
    
    ### What testing has been done on this change?
    Tested on iOS 9.3.2 with File (affected) plugin. An application does not crash anymore.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kvzaytsev/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit 8128adf86b22484f81bc0184cf3abfe0db41bf37
Author: kvzaytsev <kirill.v.zaytsev@gmail.com>
Date:   2016-06-01T08:22:54Z

    Update CDVSplashScreen.m
    
    Removing an observer surrounded with try-catch block

commit 966f5219260769b310ca3a41674cf64cccc9a734
Author: Herman Rensink <hrensink@rs.com>
Date:   2016-06-21T10:43:57Z

    CB-7497: (iOS) Fix bug with application crash
    
    Fix but with application crash on iOS on an attempt to remove observers for viewController.

    Reproducable with File file plugin.

----


> Crash on open app from fresh
> ----------------------------
>
>                 Key: CB-7497
>                 URL: https://issues.apache.org/jira/browse/CB-7497
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin SplashScreen
>         Environment: ios7 iphone 4s
>            Reporter: Miquel
>            Priority: Critical
>   Original Estimate: 2m
>  Remaining Estimate: 2m
>
> Everytime the app is fresh opened (not in the debugger)
> <Error>: *** Terminating app due to uncaught exception 'NSRangeException', reason:
'Cannot remove an observer <CDVSplashScreen 0x15d6f010> for the key path "frame" from
<UIView 0x15e614b0> because it is not registered as an observer.'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message