Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 3 May 2016 16:53:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12964696.1462290286000.99603.1462294392958@Atlassian.JIRA>
In-Reply-To: <JIRA.12964696.1462290286000@Atlassian.JIRA>
References: <JIRA.12964696.1462290286000@Atlassian.JIRA> <JIRA.12964696.1462290286543@arcas>
Subject: [jira] [Commented] (CB-11194) Improve cordova load time
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 03 May 2016 16:53:15 -0000


    [ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269058#comment-15269058 ] 

ASF GitHub Bot commented on CB-11194:
-------------------------------------

Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/434#discussion_r61915398
  
    --- Diff: cordova-lib/src/platforms/PlatformApiPoly.js ---
    @@ -474,7 +473,12 @@ function getCreateArgs(destinationDir, projectConfig, options) {
         // CB-6992 it is necessary to normalize characters
         // because node and shell scripts handles unicode symbols differently
         // We need to normalize the name to NFD form since iOS uses NFD unicode form
    -    args.push(platformName == 'ios' ? unorm.nfd(projectConfig.name()) : projectConfig.name());
    +    var name = projectConfig.name();
    +    if (platformName == 'ios') {
    +        var unorm = require('unorm');
    +        name = unorm.nfd(projectConfig.name());
    --- End diff --
    
    `name = unorm.nfd(name);`


> Improve cordova load time
> -------------------------
>
>                 Key: CB-11194
>                 URL: https://issues.apache.org/jira/browse/CB-11194
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android, CordovaLib
>            Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org