Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 3 May 2016 16:36:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12964696.1462290286000.99303.1462293372923@Atlassian.JIRA>
In-Reply-To: <JIRA.12964696.1462290286000@Atlassian.JIRA>
References: <JIRA.12964696.1462290286000@Atlassian.JIRA> <JIRA.12964696.1462290286543@arcas>
Subject: [jira] [Commented] (CB-11194) Improve cordova load time
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 03 May 2016 16:36:15 -0000


    [ https://issues.apache.org/jira/browse/CB-11194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269008#comment-15269008 ] 

ASF GitHub Bot commented on CB-11194:
-------------------------------------

Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/434#discussion_r61912923
  
    --- Diff: cordova-common/cordova-common.js ---
    @@ -17,26 +17,40 @@
         under the License.
     */
     
    -exports = module.exports = {
    -    events: require('./src/events'),
    -    superspawn: require('./src/superspawn'),
    -
    -    ActionStack: require('./src/ActionStack'),
    -    CordovaError: require('./src/CordovaError/CordovaError'),
    -    CordovaLogger: require('./src/CordovaLogger'),
    -    CordovaExternalToolErrorContext: require('./src/CordovaError/CordovaExternalToolErrorContext'),
    -    PlatformJson: require('./src/PlatformJson'),
    -    ConfigParser: require('./src/ConfigParser/ConfigParser.js'),
    -
    -    PluginInfo: require('./src/PluginInfo/PluginInfo.js'),
    -    PluginInfoProvider: require('./src/PluginInfo/PluginInfoProvider.js'),
    -    
    -    PluginManager: require('./src/PluginManager'),
    -
    -    ConfigChanges: require('./src/ConfigChanges/ConfigChanges.js'),
    -    ConfigKeeper: require('./src/ConfigChanges/ConfigKeeper.js'),
    -    ConfigFile: require('./src/ConfigChanges/ConfigFile.js'),
    -    mungeUtil: require('./src/ConfigChanges/munge-util.js'),
    -
    -    xmlHelpers: require('./src/util/xml-helpers')
    -};
    +function addProperty(obj, property, modulePath) {
    +    var val = null;
    +
    +    // Add properties as getter to delay load the modules on first invocation
    +    Object.defineProperty(obj, property, {
    +        configurable: true,
    +        get: function () {
    +            val = val || require(modulePath);
    +            ob[property] = val;
    --- End diff --
    
    Also, there should be no need to use the 'val' cache if you are overwriting obj[property].


> Improve cordova load time
> -------------------------
>
>                 Key: CB-11194
>                 URL: https://issues.apache.org/jira/browse/CB-11194
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android, CordovaLib
>            Reporter: Nikhil Khandelwal
>
> We can delay load some of our dependencies to improve our load time.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org