Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 05A4B200ACD for ; Mon, 2 May 2016 20:13:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 045951609B0; Mon, 2 May 2016 20:13:15 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 46C1A1609B3 for ; Mon, 2 May 2016 20:13:14 +0200 (CEST) Received: (qmail 30338 invoked by uid 500); 2 May 2016 18:13:13 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 29953 invoked by uid 99); 2 May 2016 18:13:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2016 18:13:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 00A3D2C1F71 for ; Mon, 2 May 2016 18:13:13 +0000 (UTC) Date: Mon, 2 May 2016 18:13:13 +0000 (UTC) From: "Raghav Katyal (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 02 May 2016 18:13:15 -0000 [ https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267154#comment-15267154 ] Raghav Katyal commented on CB-10653: ------------------------------------ [~adam.fourney@gmail.com]: Could you also tell me the use case you are trying to resolve through this change? Though this might be a relevant change, we might already be supporting that scenario already in some other way. > Universal Windows Platform -- activationContext is incomplete > ------------------------------------------------------------- > > Key: CB-10653 > URL: https://issues.apache.org/jira/browse/CB-10653 > Project: Apache Cordova > Issue Type: Improvement > Components: Windows > Environment: Windows 10, Windows 10 Phone > Reporter: Adam Fourney > Assignee: Raghav Katyal > Priority: Minor > Labels: easyfix > Original Estimate: 2h > Remaining Estimate: 2h > > CB-8674 modified cordova-js-src/platform.js to capture the application's onactivated event, and record the details in the platform.activationContext instance. > Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation events. As an example, if an app is activated by a Cortana voice command, the details are missed. See here for more details: https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx > The proposed fix is to change: > var activationHandler = function (e) { > var args = e.detail.arguments; > var actType = e.detail.type; > platform.activationContext = { type: actType, args: args }; > cordova.fireDocumentEvent('activated', platform.activationContext, true); > }; > To be: > var activationHandler = function (e) { > platform.activationContext = utils.clone(e.detail); > platform.activationContext.args = e.detail.arguments; // Backwards compatibility > cordova.fireDocumentEvent('activated', platform.activationContext, true); > }; > This also means that platform.js should require("cordova/utils") -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org