cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11343) Handle Java 9 after JEP 223
Date Tue, 31 May 2016 15:53:12 GMT

    [ https://issues.apache.org/jira/browse/CB-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307965#comment-15307965
] 

ASF GitHub Bot commented on CB-11343:
-------------------------------------

Github user codecov-io commented on the pull request:

    https://github.com/apache/cordova-android/pull/308
  
    ## [Current coverage][cc-pull] is **34.21%**
    > Merging [#308][cc-pull] into [master][cc-base-branch] will not change coverage
    
    ```diff
    @@             master       #308   diff @@
    ==========================================
      Files            11         11          
      Lines           947        947          
      Methods         194        194          
      Messages          0          0          
      Branches        153        153          
    ==========================================
      Hits            324        324          
      Misses          623        623          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d125ece...8573555][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/cordova-android/compare/d125ece9e9598f6b4f52e2148e8005f0fbabc5c8...857355503635857d7bbe017a23566fa8db7eb42f
    [cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/308?src=pr


> Handle Java 9 after JEP 223
> ---------------------------
>
>                 Key: CB-11343
>                 URL: https://issues.apache.org/jira/browse/CB-11343
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: 5.1.1
>            Reporter: Andreas Kohn
>
> `cordova requirements android` fails on a system with Java 9(-ea) installed and accessible
via PATH/JAVA_HOME:
> {code}
> $ cordova requirements android
> Requirements check results for android:
> Java JDK: not installed 
> Cannot read property '1' of null
> Android SDK: installed 
> Android target: installed android-17,android-18,android-19,android-21,android-22,android-23,android-N
> Gradle: installed 
> Error: Some of requirements check failed
> $ echo $PATH
> /usr/lib64/qt-3.3/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/andreas/.local/bin:/home/andreas/bin:/usr/java/jdk-9/bin:/home/andreas/modules/apache-maven/bin:/home/andreas/modules/apache-ant/bin:/home/andreas/modules/mongodb/bin:/home/andreas/modules/node/bin:/home/andreas/modules/android-sdk-linux/tools:/home/andreas/modules/android-sdk-linux/platform-tools
> $ which javac
> /usr/java/jdk-9/bin/javac
> $ echo $JAVA_HOME
> /usr/java/jdk-9
> $ javac -version
> javac 9-ea
> $ java -version
> java version "9-ea"
> Java(TM) SE Runtime Environment (build 9-ea+120)
> Java HotSpot(TM) 64-Bit Server VM (build 9-ea+120, mixed mode)
> {code}
> The exception is caused by the regular expression magic in check_reqs.js, `check_java`
function:
> {code}
> var match = /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
> {code}
> (5.2.0-dev is slightly different, but has the same issue).
> I think the easiest fix here is to change the expression to this:
> {code}
> var match = /javac ((?:\d+\.)*(?:\d+))/i.exec(output)[1];
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message