cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11274) Platform browser: wrong path for config.xml
Date Tue, 24 May 2016 09:57:12 GMT

    [ https://issues.apache.org/jira/browse/CB-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298012#comment-15298012
] 

ASF GitHub Bot commented on CB-11274:
-------------------------------------

Github user codecov-io commented on the pull request:

    https://github.com/apache/cordova-lib/pull/443#issuecomment-221221860
  
    ## [Current coverage][cc-pull] is **80.68%**
    > Merging [#443][cc-pull] into [master][cc-base-branch] will not change coverage
    
    ```diff
    @@             master       #443   diff @@
    ==========================================
      Files            68         68          
      Lines          5379       5379          
      Methods         851        851          
      Messages          0          0          
      Branches       1039       1039          
    ==========================================
      Hits           4340       4340          
      Misses         1039       1039          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [0e15ab4...52b0ac4][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/0e15ab45a824e690861d2f7fb501a52cc513c699...52b0ac429a6f2f9f0956919841b5670879dee3ae
    [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/443?src=pr


> Platform browser: wrong path for config.xml
> -------------------------------------------
>
>                 Key: CB-11274
>                 URL: https://issues.apache.org/jira/browse/CB-11274
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Browser
>    Affects Versions: 4.1.0
>            Reporter: Vito Macchia
>            Assignee: Sergey Shakhnazarov
>              Labels: triaged
>
> config.xml loading path is wrong: at the moment is '/config.xml' but it always fail with
cordova serve command causing some plugins not to work.
> Shouldn't it be './config.xml' or '../config.xml' instead?
> The problem is at this line here: https://github.com/apache/cordova-browser/blob/master/cordova-js-src/confighelper.js#L74
> or here https://github.com/apache/cordova-browser/blob/da6c350e91cb959937f8f45592f05387a2c98321/cordova-lib/cordova.js#L875



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message