cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11250) Fix CLI tests verifying the version
Date Wed, 11 May 2016 13:32:13 GMT

    [ https://issues.apache.org/jira/browse/CB-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280109#comment-15280109
] 

ASF GitHub Bot commented on CB-11250:
-------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-cli/pull/249

    CB-11250 Fix CLI tests verifying the version

    [Jira issue](https://issues.apache.org/jira/browse/CB-11250)
    
    `toMatch` expects regexp and the version can contain special symbols so using a check
for substring.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-cli CB-11250

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #249
    
----
commit 66df98692bcbf631711f105d50f13c2370a21427
Author: daserge <v-seshak@microsoft.com>
Date:   2016-05-11T13:18:21Z

    CB-11250 Fix CLI tests verifying the version

----


> Fix CLI tests verifying the version
> -----------------------------------
>
>                 Key: CB-11250
>                 URL: https://issues.apache.org/jira/browse/CB-11250
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> Including a commit SHA into the nightly build version is causing such a test failure:
> {noformat}
> Failures:
>   1) cordova cli options version will spit out the version with -v
>    Message:
>      Expected '6.2.0-nightly.2016.05.11+bebdebf5d851ee6f2e7f593d884ce5d0f8829b17' to
match '6.2.0-nightly.2016.05.11+bebdebf5d851ee6f2e7f593d884ce5d0f8829b17'.
>    Stacktrace:
>      Error: Expected '6.2.0-nightly.2016.05.11+bebdebf5d851ee6f2e7f593d884ce5d0f8829b17'
to match '6.2.0-nightly.2016.05.11+bebdebf5d851ee6f2e7f593d884ce5d0f8829b17'.
>     at null.<anonymous> (f:\coho\cordova-cli\spec\cli.spec.js:55:60)
>     at Timer.listOnTimeout (timers.js:92:15)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message