cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zellman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11218) Prompt method should not crash if a string is passed as button value
Date Fri, 06 May 2016 19:46:12 GMT

    [ https://issues.apache.org/jira/browse/CB-11218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274629#comment-15274629
] 

Andrew Zellman commented on CB-11218:
-------------------------------------

[~purplecabbage] I've submitted a PR for the fix at https://github.com/apache/cordova-plugin-dialogs/pull/76

> Prompt method should not crash if a string is passed as button value
> --------------------------------------------------------------------
>
>                 Key: CB-11218
>                 URL: https://issues.apache.org/jira/browse/CB-11218
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>         Environment: iOS
>            Reporter: Andrew Zellman
>            Assignee: Andrew Zellman
>              Labels: easyfix
>
> The prompt method expects an array as an argument in the command array, but there is
no input validation requiring that it be an array. A string makes just as much sense for a
single-button dialog, but if the API user sends a string, it crashes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message