cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11176) Fix windows-splashscreen compatibility with older plugin versions
Date Wed, 04 May 2016 14:30:13 GMT

    [ https://issues.apache.org/jira/browse/CB-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270713#comment-15270713
] 

ASF GitHub Bot commented on CB-11176:
-------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/172#discussion_r62048444
  
    --- Diff: cordova-js-src/exec.js ---
    @@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
      */
     module.exports = function (success, fail, service, action, args) {
     
    +    // Handle the case when we have an old version of splashscreen plugin to avoid the
API calls failures
    +    if (service === 'SplashScreen') {
    +        var pluginsVersions = require("cordova/plugin_list").metadata;
    +        var splashscreenVersion = pluginsVersions['cordova-plugin-splashscreen'];
    +        var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
    +        if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) <
MIN_SPLASHSCREEN_SUPPORTED_VER) {
    --- End diff --
    
    This regards to the plugin version and not to the platform' one,  i.e. it should work
starting with cordova-plugin-splashscreen@4 (as it will just redirect API calls to the platform).


> Fix windows-splashscreen compatibility with older plugin versions
> -----------------------------------------------------------------
>
>                 Key: CB-11176
>                 URL: https://issues.apache.org/jira/browse/CB-11176
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Shakhnazarov
>
> Manual splashscreen hiding using {{AutoHideSplashScreen=false}} preference with a {{navigator.splashscreen.hide()}}
call does not work with updated {{cordova-windows}} and an old {{cordova-plugin-splashscreen}}
(<4).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message