cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10784) Unable to use Cordova Plugins that use a native view directly on pickContacts callback.
Date Tue, 17 May 2016 21:52:12 GMT

    [ https://issues.apache.org/jira/browse/CB-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287678#comment-15287678
] 

ASF GitHub Bot commented on CB-10784:
-------------------------------------

Github user cordova-qa commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/107#issuecomment-219865361
  
    Cordova CI Build has completed successfully. 
    
    **Commit**     - [Link](https://github.com/apache/cordova-plugin-contacts/pull/107/commits/a75d1198d01980b37d112ae515223812513b10d6)
    **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3/)
    
    | Builder Name  | Console Output | Test Report | Device Logs  |
    |     :---:     |     :---:      |   :---:     |     :---:    |
    | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-store/artifact/)
|
    | [Windows 10  Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-10-store/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-10-store/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-10-store/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-10-store/artifact/)
|
    | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-phone/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-phone/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-phone/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=windows-slave,platformName=windows-8.1-phone/artifact/)
|
    | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=ios/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=ios/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=ios/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=ios/artifact/)
|
    | [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=android/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=android/console)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=android/testReport/)
| [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/3//label=mac-slave,platformName=android/artifact/)
|
     



> Unable to use Cordova Plugins that use a native view directly on pickContacts callback.
> ---------------------------------------------------------------------------------------
>
>                 Key: CB-10784
>                 URL: https://issues.apache.org/jira/browse/CB-10784
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>    Affects Versions: Master
>         Environment: iOS
>            Reporter: Cory Thompson
>            Priority: Minor
>              Labels: ios, pendingPR, triaged
>
> I attempted to open a native dialog directly after a using pickContacts and receive the
following error on iOS.
> navigator.contacts.pickContact(onContactItemPickedSuccess, onContactItemPickedError);
> function onContactItemPickedSuccess(contact) {
>      navigator.notification.confirm(…);
> }
> Warning: Attempt to present <UIAlertController: 0x14a83600> on <CDVContactsPicker:
0x151e7400> whose view is not in the window hierarchy!
> A workaround is wrap the confirmation code using a JavaScript setTimeout for 1000ms.
> I’ve dug into the Objective C code and what I suspect is happening is that the successCallback
is called before the animation for closing the CDVContactsPicker has finished.
> I’ve tested moving the callback after the close animation and my issue is resolved.
I will include a pull request in the comments.
> The only potential problem I see with this is the original author may have decided to
return before animation close so that a user could update the HTML behind the contactPicker
therefore appearing to load much faster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message