Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 34C86194FA for ; Mon, 25 Apr 2016 22:05:13 +0000 (UTC) Received: (qmail 37470 invoked by uid 500); 25 Apr 2016 22:05:13 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 37443 invoked by uid 500); 25 Apr 2016 22:05:13 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 37379 invoked by uid 99); 25 Apr 2016 22:05:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 22:05:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D6B382C1F61 for ; Mon, 25 Apr 2016 22:05:12 +0000 (UTC) Date: Mon, 25 Apr 2016 22:05:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-11142) Fix the NeedPermission code for the case when external media is not mounted in Android MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257134#comment-15257134 ] ASF GitHub Bot commented on CB-11142: ------------------------------------- Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214543607 LGTM > Fix the NeedPermission code for the case when external media is not mounted in Android > -------------------------------------------------------------------------------------- > > Key: CB-11142 > URL: https://issues.apache.org/jira/browse/CB-11142 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File > Reporter: Raghav Katyal > Assignee: Raghav Katyal > Labels: Android > > Line 582 in FileUtils.java has: > String[] allowedStorageDirectories = {j.getString("applicationStorageDirectory"), j.getString("externalApplicationStorageDirectory")}; > This would cause an JSON exception when "externalApplicationStorageDirectory" is not present, which happens when the external storage is not mounted in the device/emulator. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org