Return-Path: 
 <issues-return-65372-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DF8E018E39
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Tue, 19 Apr 2016 15:06:25 +0000 (UTC)
Received: (qmail 55800 invoked by uid 500); 19 Apr 2016 15:06:25 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 55777 invoked by uid 500); 19 Apr 2016 15:06:25 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 55702 invoked by uid 99); 19 Apr 2016 15:06:25 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 15:06:25 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 793892C1F64
	for <issues@cordova.apache.org>; Tue, 19 Apr 2016 15:06:25 +0000 (UTC)
Date: Tue, 19 Apr 2016 15:06:25 +0000 (UTC)
From: "Roberto Andrade (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12914166.1447865590000.267733.1461078385494@Atlassian.JIRA>
In-Reply-To: <JIRA.12914166.1447865590000@Atlassian.JIRA>
References: <JIRA.12914166.1447865590000@Atlassian.JIRA>
 <JIRA.12914166.1447865590344@arcas>
Subject: [jira] [Commented] (CB-10034) Plugins iOS Custom Frameworks are
 added to "Embedded Binaries" XCode project section by default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247921#comment-15247921 ] 

Roberto Andrade commented on CB-10034:
--------------------------------------

For testing I also provided supporting tests that confirm the old behavior was still observed when no additional attributes were provided. Everything should behave just like before, things start changing when disabling the "embed" and "link" flags.

> Plugins iOS Custom Frameworks are added to "Embedded Binaries" XCode project section by default
> -----------------------------------------------------------------------------------------------
>
>                 Key: CB-10034
>                 URL: https://issues.apache.org/jira/browse/CB-10034
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 5.4.0, 5.3.3
>         Environment: OSX developing for iOS
>            Reporter: Roberto Andrade
>
> Since CB-9517 was merged and released in 5.3.0 it seems to have changed the approach to adding a "custom framework" dependency declared in {{plugin.xml}} with the {{<framework custom="true"/>}} directive into the xcode project, as per the [following change|https://github.com/apache/cordova-lib/commit/737f2df4e5c8de205c90cc29614483ebcd71f605].
> It assumes all frameworks are "embeddable", which is not true for a great chunk of frameworks out there that have not being built with the new iOS 8/XCode 6 Cocoa Framework architecture. Most of the frameworks I use (developed prior to Apple coming up with the "official" iOS 8 Framework utilities and Xcode project options) use community provided [iOS-Universal-Framework|https://github.com/kstenerud/iOS-Universal-Framework], which once an artifact generated using that project template gets added to the "embedded binaries" section of a depending app (ie: Cordova app), Xcode has issues doing its thing because they were not built with the iOS 8 framework magic in it.
> I suggest that the new behavior be the default (ie: add it to the embedded binaries section) but provide an option when declaring the framework dependency in {{plugin.xml}} so that we can override the behavior and specify whether or not we want it to the embedded (at that point the old <=5.2.0 behavior should take over, ie: just add it to the list of framework dependencies but not the the embedded binaries section of the project), may I suggest:
> {{<framework custom="true" embed="false"/>}}
> as the optional override (being assumed as {{true}} by default)?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org