cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11117) Preparing platforms should skip copying files which haven't changed
Date Tue, 19 Apr 2016 21:02:25 GMT

    [ https://issues.apache.org/jira/browse/CB-11117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248634#comment-15248634
] 

ASF GitHub Bot commented on CB-11117:
-------------------------------------

GitHub user jasongin opened a pull request:

    https://github.com/apache/cordova-android/pull/295

    CB-11117: Use FileUpdater to optimize prepare for android platform

    This uses the FileUpdater module added in https://github.com/apache/cordova-lib/pull/429
to optionally skip copying files that didn't change. Some refactoring was required because
previously the target directories would just be wiped before copying; now we need to map out
the source and target directories so the FileUpdater has the necessary information to determine
the optimal set of file operations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasongin/cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #295
    
----
commit c8e504de768aa373874fd2f8895b497c5581652b
Author: Jason Ginchereau <jasongin@microsoft.com>
Date:   2016-04-19T20:28:13Z

    CB-11117: Use FileUpdater to optimize prepare for android platform

----


> Preparing platforms should skip copying files which haven't changed
> -------------------------------------------------------------------
>
>                 Key: CB-11117
>                 URL: https://issues.apache.org/jira/browse/CB-11117
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, iOS, Windows
>            Reporter: Jason Ginchereau
>            Assignee: Jason Ginchereau
>
> Many cordova CLI commands include a "prepare" operation, including 'cordova build', 'cordova
run', 'cordova plugin add', and more. Every time each of those commands runs, the target platform
is "prepared", which involves copying all files from the [<project>/www, <project>/platforms/<platform>/platform_www,
<project>/merges/<platform>] to the platform's target www folder, as well as copying
a bunch of icons and splash screens to platform-specific locations.
> For the very first prepare of a platform, all that file copying is necessary. But most
of the time after that most of the files being copied have not changed and therefore don't
really need to be copied again. So the typical developer inner loop (edit a few source files,
build and run the app, repeat) is a lot slower than it could be for a Cordova project, especially
one that includes a significant number of source files or resources.
> Instead, Cordova should be smart enough to skip copying of files that haven't changed,
based on their last-modified timestamp. (But also there should still be a way to force a clean/full/non-incremental
build if desired.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message