cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11085) AudioHandler logs should use system log, not println
Date Tue, 19 Apr 2016 09:43:25 GMT

    [ https://issues.apache.org/jira/browse/CB-11085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247439#comment-15247439
] 

ASF GitHub Bot commented on CB-11085:
-------------------------------------

Github user fafaman commented on the pull request:

    https://github.com/apache/cordova-plugin-media/pull/93#issuecomment-211828264
  
    @omefire I am not too keen on seeking to the end of file: Is this module not supposed
to be able to play a stream? To be clear, this patch was done while looking after a problem
of codrova app restarting when the phone is plugged or unplugged from a car audio stand. I
seams that an event telling the app the audio system has changed provoques that app restart.
I first thought the app restart was due to that null pointer exception, but once fixed, the
app still restarts... I decided to propose the patch (as well as CB-11085) so this work is
not lost, and code cleaner for going forward. In my opinion, the real problem comes from before
during the player creation: we should not have  this.players.get(id) returning a non null
while the player is null.


> AudioHandler logs should use system log, not println
> ----------------------------------------------------
>
>                 Key: CB-11085
>                 URL: https://issues.apache.org/jira/browse/CB-11085
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, Plugin Media
>    Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0, 1.6.1, 1.7.0, 1.8.0,
1.8.1, 1.9.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, 2.8.0, 2.9.0, 3.0.0,
3.1.0, 3.2.0, 3.3.0, 3.4.0, 2.9.1, 3.5.0
>            Reporter: Fabrice Lebas
>            Priority: Minor
>              Labels: easyfix, test
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> AudioHandler.java should use android.util.Log rather than println.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message