cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2083) Cordova for WP8 getPicture Leaves Photos in Camera Roll
Date Wed, 13 Apr 2016 19:56:25 GMT

    [ https://issues.apache.org/jira/browse/CB-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239929#comment-15239929
] 

ASF GitHub Bot commented on CB-2083:
------------------------------------

Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59614155
  
    --- Diff: jsdoc2md/TEMPLATE.md ---
    @@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of
     [web_activities]: https://hacks.mozilla.org/2013/01/introducing-web-activities/
     [wp8_bug]: https://issues.apache.org/jira/browse/CB-2083
     [msdn_wp8_docs]: http://msdn.microsoft.com/en-us/library/windowsphone/develop/hh394006.aspx
    +
    +## Sample: Take Pictures, Select Pictures from the Picture Library, and Get Thumbnails
<a name="sample"></a>
    +
    +The Camera plugin allows you to do things like open the device's Camera app and take
a picture, or open the file picker and select one. The code snippets in this section demonstrate
different tasks including:
    +
    +* Open the Camera app and [take a Picture](#takePicture)
    +* Take a picture and [return thumbnails](#getThumbnails) (resized picture)
    +* Take a picture and [generate a FileEntry object](#convert)
    +* [Select a file](#selectFile) from the picture library
    +* Select a JPEG image and [return thumbnails](#getFileThumbnails) (resized image)
    +* Select an image and [generate a FileEntry object](#convert)
    +
    +## Take a Picture <a name="takePicture"></a>
    +
    +Before you can take a picture, you need to set some Camera plugin options to pass into
the Camera plugin's `getPicture` function. Here is a common set of recommendations. In this
example, you create the object that you will use for the Camera options, and set the `sourceType`
dynamically to support both the Camera app and the file picker.
    +
    +```js
    +function setOptions(srcType) {
    +    var options = {
    +        // Some common settings are 20, 50, and 100
    +        quality: 50,
    +        destinationType: Camera.DestinationType.FILE_URI,
    +        // In this app, dynamically set the picture source, Camera or photo gallery
    +        sourceType: srcType,
    +        encodingType: Camera.EncodingType.JPEG,
    +        mediaType: Camera.MediaType.PICTURE,
    +        allowEdit: true,
    +        correctOrientation: true  //Corrects Android orientation quirks
    +    }
    +    return options;
    +}
    +```
    +
    +Typically, you want to use a FILE_URI instead of a DATA_URL to avoid most memory issues.
JPEG is the recommended encoding type for Android.
    +
    +You take a picture by passing in the options object to `getPicture`, which takes a CameraOptions
object as the third argument. When you call `setOptions`, pass `Camera.PictureSourceType.CAMERA`
as the picture source.
    +
    +```js
    +function openCamera(selection) {
    +
    +    var srcType = Camera.PictureSourceType.CAMERA;
    +    var options = setOptions(srcType);
    +    var func = copyToFile;
    +
    +    navigator.camera.getPicture(function cameraSuccess(imageUri) {
    +
    +        displayImage(imageUri);
    +        // You may choose to copy the picture, save it somewhere, or upload.
    +        func(imageUri);
    +
    +    }, function cameraError(error) {
    +        console.debug("Unable to obtain picture: " + error, "app");
    +
    +    }, options);
    +}
    +```
    +
    +Once you take the picture, you can display it or do something else. In this example,
call the app's `displayImage` function from the preceding code.
    +
    +```js
    +function displayImage(imgUri) {
    +
    +    var elem = document.getElementById('imageFile');
    +    elem.src = imgUri;
    +}
    +```
    +
    +## Take a Picture and Return Thumbnails (Resize the Picture) <a name="getThumbnails"></a>
    +
    +To get smaller images, you can return a resized image by passing both `targetHeight`
and `targetWidth` values with your CameraOptions object. In this example, you resize the returned
image to fit in a 100px by 100px box (the aspect ratio is maintained, so 100px is either the
height or width, whichever is greater in the source).
    +
    +```js
    +function openCamera(selection) {
    +
    +    var srcType = Camera.PictureSourceType.CAMERA;
    +    var options = setOptions(srcType);
    +    var func = copyToFile;
    +
    +    if (selection == "camera-thmb") {
    +        options.targetHeight = 100;
    +        options.targetWidth = 100;
    +    }
    +
    +    navigator.camera.getPicture(function cameraSuccess(imageUri) {
    +
    +        // Do something
    +
    +    }, function cameraError(error) {
    +        console.debug("Unable to obtain picture: " + error, "app");
    +
    +    }, options);
    +}
    +```
    +
    +## Select a File from the Picture Library <a name="selectFile"></a>
    +
    +When selecting a file using the file picker, you also need to set the CameraOptions object.
In this example, set the `sourceType` to `Camera.PictureSourceType.SAVEDPHOTOALBUM`. To open
the file picker, call `getPicture` just as you did in the previous example, passing in the
success and error callbacks along with CameraOptions object.
    +
    +```js
    +function openFilePicker(selection) {
    +
    +    var srcType = Camera.PictureSourceType.SAVEDPHOTOALBUM;
    +    var options = setOptions(srcType);
    +    var func = copyToFile;
    +
    +    navigator.camera.getPicture(function cameraSuccess(imageUri) {
    +
    +        // Do something
    +
    +    }, function cameraError(error) {
    +        console.debug("Unable to obtain picture: " + error, "app");
    +
    +    }, options);
    +}
    +```
    +
    +## Select an Image and Return Thumbnails (resized images) <a name="getFileThumbnails"></a>
    +
    +Resizing a file selected with the file picker works just like resizing using the Camera
app. If you are using the file picker instead of the Camera, and you are resizing the image,
the `Camera.EncodingType` value must match the value for the selected image. We previously
set this value to JPEG in the app's `setOptions` function.
    --- End diff --
    
    Cool! That has confused me in the past as well and comes up on Slack sometimes too. Might
be worth documenting!


> Cordova for WP8 getPicture Leaves Photos in Camera Roll
> -------------------------------------------------------
>
>                 Key: CB-2083
>                 URL: https://issues.apache.org/jira/browse/CB-2083
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: WP8 (deprecated)
>    Affects Versions: 2.2.0
>         Environment: Windows Phone 8
>            Reporter: Alan Neveu
>            Assignee: Jesse MacFadyen
>            Priority: Minor
>              Labels: Annoyance, Enhancement
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> getPicture with FileURI does not work, it crashes.
> getPicture with DataURL works, but it leaves a copy of the photo on the phone's Camera
Roll.  The user then gets very frustrated because they have this mess of photos from your
app cluttering up their personal photos, and then have to delete them.  If they are using
SkyDrive on Windows Phone 8, they will also have a copy of every photo automatically saved
to their SkyDrive account, which then they have to delete from there as well, cursing your
app with every delete operation.  Oh, I think that in Windows Phone 7 this is not the case,
but it is the case with Windows Phone 8.
> It turns out this is due to the CameraCaptureTask function, which makes it exceedingly
simple to get a photo but has this undesirable side effect. You cannot just delete the file,
though, because of a security exception.
> The solution is to re-write Camera.cs so that it uses the full camera API rather than
just the CameraCaptureTask function.  That's a couple days of labor, for sure, but someone
needs to do this or else the Windows Phone 8 platform will suffer from this annoying bug for
all that rely on Cordova.  When asked why their app has this annoyance the reply will be "Ah,
it's one of those stupid phonegap apps..."  I hate that answer.  So I hope that someone who
has the time will contribute to this issue.  I will give it a try in a few weeks when I finish
up the projects that I have been putting on hold while upgrading my app to Windows Phone 8
capable, but I just can't get to it for a few weeks.  I am hoping that this summary will help
someone else get a jump start on this issue as they won't have to do so much preliminary research
before starting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message