Return-Path: 
 <issues-return-62718-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org
Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 89DB81988E
	for <apmail-cordova-issues-archive@minotaur.apache.org>;
 Wed, 16 Mar 2016 16:44:36 +0000 (UTC)
Received: (qmail 18474 invoked by uid 500); 16 Mar 2016 16:44:34 -0000
Delivered-To: apmail-cordova-issues-archive@cordova.apache.org
Received: (qmail 18443 invoked by uid 500); 16 Mar 2016 16:44:34 -0000
Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@cordova.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@cordova.apache.org>
List-Post: <mailto:issues@cordova.apache.org>
List-Id: <issues.cordova.apache.org>
Delivered-To: mailing list issues@cordova.apache.org
Received: (qmail 18159 invoked by uid 99); 16 Mar 2016 16:44:34 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2016 16:44:34 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 83CE02C1F80
	for <issues@cordova.apache.org>; Wed, 16 Mar 2016 16:44:34 +0000 (UTC)
Date: Wed, 16 Mar 2016 16:44:34 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@cordova.apache.org
Message-ID: <JIRA.12920789.1449761692000.37582.1458146674537@Atlassian.JIRA>
In-Reply-To: <JIRA.12920789.1449761692000@Atlassian.JIRA>
References: <JIRA.12920789.1449761692000@Atlassian.JIRA>
 <JIRA.12920789.1449761692271@arcas>
Subject: [jira] [Commented] (CB-10178) Unclear windows phone documentation
 for icons and splash screens
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197654#comment-15197654 ] 

ASF GitHub Bot commented on CB-10178:
-------------------------------------

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/558#discussion_r56368991
  
    --- Diff: www/docs/en/dev/config_ref/images.md ---
    @@ -119,6 +120,45 @@ different screen resolutions.
     - [App icon and image size guidelines](https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/IconMatrix.html)
     
     ##Windows
    +
    +For Windows the recommended approach to define app icons is to use `target` attribute.
    +
    +```xml
    +    <platform name="windows">
    +        <icon src="res/windows/storelogo.png" target="StoreLogo" />
    +        <icon src="res/windows/smalllogo.png" target="Square30x30Logo" />
    +        <icon src="res/Windows/Square44x44Logo.png" target="Square44x44Logo" />
    +        <icon src="res/Windows/Square70x70Logo.png" target="Square70x70Logo" />
    +        <icon src="res/Windows/Square71x71Logo.png" target="Square71x71Logo" />
    +        <icon src="res/Windows/Square150x150Logo.png" target="Square150x150Logo" />
    +        <icon src="res/Windows/Square310x310Logo.png" target="Square310x310Logo" />
    +        <icon src="res/Windows/Wide310x150Logo.png" target="Wide310x150Logo" />
    +    </platform>
    +```
    +
    +where `source` is the path to the icon which needs to be added.
    +
    +Please note that Windows platform handles MRT icons automatically, so if you specify `src="res/windows/storelogo.png"` the following files will be copied into app's `images` folder: `res/windows/storelogo.scale-100.png`, `res/windows/storelogo.scale-200.png`, etc.
    +
    +The `target` attribute specifies the base name for resultant icons. For every icon file destination filename is calculated as `target + '.' + MRT_qualifiers + extension(src)`. For the icons to display properly in resultant app every `target` value should be the one of icon filenames, defined in application's `.appxmanifest` file.
    +
    +Summarizing the above, using `target` attribute it is possible to:
    +
    +  * define a group of icons for different device scale factors using single `<icon ...>` element, for example:
    +```xml
    +    <icon src="res/Windows/AppListIcon.png" target="Square44x44Logo.png" />
    --- End diff --
    
    Should `target` have extension or not?


> Unclear windows phone documentation for icons and splash screens
> ----------------------------------------------------------------
>
>                 Key: CB-10178
>                 URL: https://issues.apache.org/jira/browse/CB-10178
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 5.4.0
>         Environment: Phonegap CLI, building to Windows platform. Testing on physical windows phone device and on windows phone emulator. 
>            Reporter: Rupert McKay
>            Assignee: Nikhil Khandelwal
>            Priority: Minor
>              Labels: Docs-6.x, triaged, windows
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/images.md
> In the section 'Configuring Icons in the CLI' the windows sections neglect to mention the affect adding a .scale-100 or .scale-240 extension can have to how source images get mapped to destination images. 
> The examples provided will all default to mapping onto .scale-100. 
> Recommend adding examples like the following:
> {code:xml}
>     <platform name="windows">
>         <icon src="www/res/windows/SplashScreenPhone.scale-240.png" width="1152" height="1920" />
>         <icon src="www/res/windows/Square30x30Logo.scale-100.png" width="30" height="30" />
>         <icon src="www/res/windows/Square44x44Logo.scale-100.png" width="44" height="44" />
>         <icon src="www/res/windows/Square44x44Logo.scale-240.png" width="106" height="106" />
>         <icon src="www/res/windows/Square70x70Logo.scale-100.png" width="70" height="70" />
>         <icon src="www/res/windows/Square71x71Logo.scale-100.png" width="71" height="71" />
>         <icon src="www/res/windows/Square71x71Logo.scale-240.png" width="170" height="170" />
>         <icon src="www/res/windows/Square150x150Logo.scale-100.png" width="150" height="150" />
>         <icon src="www/res/windows/Square150x150Logo.scale-240.png" width="360" height="360" />
>         <icon src="www/res/windows/Square310x310Logo.scale-100.png" width="310" height="310" />
>         <icon src="www/res/windows/StoreLogo.scale-100.png" width="50" height="50" />
>         <icon src="www/res/windows/StoreLogo.scale-240.png" width="120" height="120" />
>         <icon src="www/res/windows/Wide310x150Logo.scale-240.png" width="744" height="360" />
>         <icon src="www/res/windows/Wide310x150Logo.scale-100.png" width="310" height="150" />
>         <splash src="www/res/windows/SplashScreen.scale-100.png" width="620" height="300" />
>     </platform>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org